fix: installation of dependencies on Windows #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! I hadn't fully tested everything on Windows yet so glad that you managed to get a fix for it! One of the tests for it is failing because you changed the extension. Can you adjust that test to reflect your change? |
|
Sure! I changed the test. |
wolfenrain
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Installing the dependencies was giving me the following error:
Bad state: No element #0 ListMixin.firstWhere (dart:collection/list.dart:167:5) #1 FileExtractor.extract (package:umbra_cli/src/workers/file_extractor.dart:26:26) ...I managed to track the problem to the fact that the FileExtractor was expecting a file named "install/bin/glslc" in the archive, but the actual name is "install/bin/glslc.exe" (for Windows). Also, the file was being saved as "glslc" and not as "glslc.exe", as it should on Windows.
I just added the ".exe" to the end of the file names, when installing the dependencies and the platform is Windows. Creating and generating the shaders is working for me now.
Type of Change