Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TourTag Filter causes SQL error when using "No Category" view on Tour Book #220

Closed
rtdog opened this issue Aug 12, 2020 · 3 comments
Closed

Comments

@rtdog
Copy link
Contributor

rtdog commented Aug 12, 2020

I suspect you know this @wolfgang-ch , but if you use the Tour Tag filter and have the new "No Category" view layout selected on the "Tour Book" view, then you get a SQL error because the tag ID isn't in the table.

2020-08-12_8-28-40

@FJBDev
Copy link
Collaborator

FJBDev commented Aug 12, 2020

Nice find @rtdog . Is that a regression that appeared in 20.8 ? or has it been present for several versions already ?

@wolfgang-ch
Copy link
Collaborator

I've never seen this error otherwise I've fixed it. The new flat tour book view can be the reason that there are still some issues. Tags are not yet displayed in the flat view, this needs to be implemented.

wolfgang-ch added a commit that referenced this issue Aug 23, 2020
requires complex sql, it looks good now but needs more testing
@wolfgang-ch
Copy link
Collaborator

fixed

mt-flat-view-with-tag-filter

wolfgang-ch added a commit that referenced this issue Aug 25, 2020
#220

now the sql statements are much more complex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants