Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map25 wording "create Tour Marker" #331

Merged
merged 43 commits into from Apr 18, 2021
Merged

Conversation

telemaxx
Copy link
Contributor

No description provided.

telemaxx and others added 30 commits July 28, 2020 17:34
…nal thumb but this was not the reason to remove it, this image was NEVER disposed -> SWT was running very fast out of handles when moving the tour chart slider as this would create a new image for every new slider position, discovered this issue with SWT sleak"

This reverts commit d3e09e3.
many changes in Libs...
ItemizedLayer
Mutable marker
avoid nullpointer when photolist is empty
and avoiding nullpointer again. 1sr try was nor working.
setting image quality from thumb to HQ
Merge remote-tracking branch 'origin/main' into map25

Conflicts:
	bundles/net.tourbook/src/net/tourbook/map25/Map25App.java
	bundles/net.tourbook/src/net/tourbook/map25/Map25View.java
	bundles/net.tourbook/src/net/tourbook/map25/layer/marker/PhotoToolkit.java
	bundles/net.tourbook/src/net/tourbook/map25/ui/SlideoutMap25_MapOptions.java
	bundles/net.tourbook/src/net/tourbook/messages.properties
something is going wrong with git, that was the second time.
increased stepsize in slideout from 5 to 10
was different in create marker from chart

the wording i copied from net/tourbook/map2/messages*.properties to
net/tourbook/messages*.properties for all languages.
Conflicts:
	info/release-notes/21.next.0-readme.txt
@telemaxx
Copy link
Contributor Author

if merged the feature request can be closed:
https://sourceforge.net/p/mytourbook/feature-requests/192/

tourCatalog_view_action_create_marker = Vytvo\u0159it &zna\u010Dku
tourCatalog_view_action_create_marker = Vytvo\u0159it
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@telemaxx Are you doing now the translations :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was easy, in this case.
just copy past/from the other messages.properties.

but i keep the shortcuts

@wolfgang-ch
Copy link
Collaborator

Still having the issue that the thumb image is scaled

mt map 25 photos

@telemaxx
Copy link
Contributor Author

i know, i had reverted my changes for that.
it had looked good, but when i load a tour with many photos, it crashes.

can you try, what happens, when you change this line:
https://github.com/wolfgang-ch/mytourbook/blob/df98402e4bb417c74301276a260e92439911ea94/bundles/net.tourbook/src/net/tourbook/map25/layer/marker/PhotoToolkit.java#L304

to:

final ImageQuality requestedImageQuality = ImageQuality.HQ;

HQ seems to be to much.

@wolfgang-ch
Copy link
Collaborator

When I changed it to the HQ quality, then MT crashed sometimes but the image quality is better :-)

mt map25 photos

I also tried to reduced the cache and photo quality size and it seems to crash less, but still.

I also discovered that photos in the tour photo view are not always loaded with higher quality when the image size is larger than the thumb size (when photos are displaying a small red-orange square in the corner)

mt map25 photos quality

mt map25 photos cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants