Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TourChart Pauses Improvement: Added a tour pauses slideout to know the start and end times of a given pause #394

Merged
merged 114 commits into from Sep 14, 2021
Merged

TourChart Pauses Improvement: Added a tour pauses slideout to know the start and end times of a given pause #394

merged 114 commits into from Sep 14, 2021

Conversation

FJBDev
Copy link
Collaborator

@FJBDev FJBDev commented Sep 13, 2021 •
edited

image

image

Unit tests 100% successful
image

FJBDev added 30 commits May 20, 2021 21:15
@FJBDev
Adding a tooltip for the chart pauses
8dacfb6
@FJBDev
Merge remote-tracking branch 'Wolfgang/main' into fb-pauseslideout
def1f5a
@FJBDev
Slideout for tour chart pauses
8324920
@FJBDev
wip
a49975e
@FJBDev
Merge remote-tracking branch 'Wolfgang/main' into fb-pauseslideout
1412415
@FJBDev
WIP
bb614c8
@FJBDev
WIP
4657c67
@FJBDev
Cleanup
62f60f1
@FJBDev
Merge remote-tracking branch 'Wolfgang/main' into fb-pauseslideout
8bc82af
@FJBDev
Segregating marker char labels from pause chart labels
60adc09
@FJBDev
THe rest
65563f7
@FJBDev
Now introducing it for the night sections
4e361f9
@FJBDev
WIP
d697360
@FJBDev
Cleanup
a3f68b1
@FJBDev
Misc
975afef
@FJBDev
Finniky but it works!
f01b3df
@FJBDev
Still lots to do but making progress
c6d5bf1
@FJBDev
todo
32deff1
@FJBDev
wip
28ceb9c
@FJBDev
Misc
8077f14
@FJBDev
Merge remote-tracking branch 'Wolfgang/main' into fb-pauseslideout
2ccc5f2
@FJBDev
Now he pause slideout shows every time
a8be718
@FJBDev
Misc
237af79
@FJBDev
Drawing hovered pauses
c007ab8
@FJBDev
Clean up
a6c845d
@FJBDev
Fix for the pauses slideout
591570d
@FJBDev
UI work
c4af942
@FJBDev
WIP
9585c25
@FJBDev
Cleanup
87cf441
@FJBDev
WIP
2bbc02a
root and others added 23 commits September 11, 2021 08:33
Merge remote-tracking branch 'wolfgang/main' into fb-pauseslideout
d1bb7c6 
Conflicts:
	bundles/net.tourbook.device.garmin.fit/src/net/tourbook/device/garmin/fit/FitData.java
	bundles/net.tourbook.device.garmin/src/net/tourbook/device/garmin/messages_fr.properties
	bundles/net.tourbook.device/src/net/tourbook/device/crp/CRPDataReader.java
	bundles/net.tourbook.device/src/net/tourbook/device/polar/hrm/Polar_HRM_DataReader.java
	bundles/net.tourbook.device/src/net/tourbook/device/polartrainer/PolarTrainerSAXHandler.java
	bundles/net.tourbook.device/src/net/tourbook/device/sporttracks/FitLogSAXHandler.java
	bundles/net.tourbook/src/net/tourbook/data/TourData.java
Merge remote-tracking branch 'origin/fb-enhancements' into fb-pausesl…
8dd785d 
…ideout
Merge part 2
8cd1640
Merge remote-tracking branch 'wolfgang/main' into fb-pauseslideout
e3dfca0 
Conflicts:
	bundles/net.tourbook.device.garmin/src/net/tourbook/device/garmin/GarminExternalDevice.java
	bundles/net.tourbook.device.garmin/src/net/tourbook/device/garmin/Messages.java
	bundles/net.tourbook.device.garmin/src/net/tourbook/device/garmin/messages.properties
	bundles/net.tourbook.device.garmin/src/net/tourbook/device/garmin/messages_cs.properties
	bundles/net.tourbook.device.garmin/src/net/tourbook/device/garmin/messages_de.properties
	bundles/net.tourbook.device.garmin/src/net/tourbook/device/garmin/messages_es.properties
	bundles/net.tourbook.device.garmin/src/net/tourbook/device/garmin/messages_fr.properties
	bundles/net.tourbook.device.garmin/src/net/tourbook/device/garmin/messages_it.properties
	bundles/net.tourbook.device.garmin/src/net/tourbook/device/garmin/messages_nl.properties
	bundles/net.tourbook/src/net/tourbook/ui/views/tourMarker/TourMarkerView.java
Fix
ffe4f2c
Merge
f3a960e
Fix
6e7fe5a
@FJBDev
hard
057c110
@FJBDev
WIP
1f5ac5e
Merge remote-tracking branch 'wolfgang/main' into fb-pauseslideout
8f9d630
@FJBDev
WIP
1f64507
@FJBDev
WIP
4e9e987
@FJBDev
Fix
9df921a
@FJBDev
Readme update
3a945f9
@FJBDev
Good for now
87cd8e2
@FJBDev
Fixes
b601581
@FJBDev
Merge remote-tracking branch 'Wolfgang/main' into fb-pauseslideout
fa58dcb
@FJBDev
Not needed
4cf3cb5
@FJBDev
Still work to do
7f1711a
@FJBDev
Fixed
67cb378
@FJBDev
to do in another PR
7c4dfff
@FJBDev
Cleanup
ec835bb
@FJBDev
Ignoring the SRTM data retrieval
6c63028
@FJBDev FJBDev mentioned this pull request Sep 13, 2021
Closed
@wolfgang-ch wolfgang-ch merged commit 4a509d9 into mytourbook:FJBDev Sep 14, 2021
wolfgang-ch
wolfgang-ch reviewed Sep 14, 2021
View reviewed changes
Copy link
Collaborator

@wolfgang-ch wolfgang-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took you some time to implement this "simple" tooltip and I still found a few minor issues.
It took me also about 4 weeks of intensively work to implement the concurrent import feature.

image

Because of these issues, I did not merge it yet into main

bundles/net.tourbook/src/net/tourbook/map2/view/Map2View.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/tour/TourEventId.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/ui/tourChart/action/ActionTourChartPauses.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/ui/tourChart/ChartLayerPause.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/ui/tourChart/TourChart.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/ui/tourChart/TourChart.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/ui/tourChart/TourChart.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/Messages.java Show resolved Hide resolved
bundles/net.tourbook.common/src/net/tourbook/common/messages.properties Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/ui/tourChart/action/ActionTourChartPauses.java Show resolved Hide resolved
@wolfgang-ch
Copy link
Collaborator

New themed system tooltips are working with Eclipse 21-09 RC2a :-)

image

before

image

@FJBDev
Copy link
Collaborator Author

FJBDev commented Sep 14, 2021

New themed system tooltips are working with Eclipse 21-09 RC2a :-)

Does that mean that the next version of MT will use Eclipse 2021-09 ?

@FJBDev
Copy link
Collaborator Author

FJBDev commented Sep 14, 2021

It took you some time to implement this "simple" tooltip and I still found a few minor issues.
It took me also about 4 weeks of intensively work to implement the concurrent import feature.

I had the idea of the pause slideout back then but it doesn't mean I started at that time.

@wolfgang-ch
Copy link
Collaborator

New themed system tooltips are working with Eclipse 21-09 RC2a :-)

Does that mean that the next version of MT will use Eclipse 2021-09 ?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgang-ch wolfgang-ch wolfgang-ch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FJBDev @wolfgang-ch