Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support frame events from Chrome tracing #456

Closed
jkriegshauser opened this issue Aug 31, 2022 · 2 comments
Closed

Support frame events from Chrome tracing #456

jkriegshauser opened this issue Aug 31, 2022 · 2 comments

Comments

@jkriegshauser
Copy link
Contributor

This issue is to start a discussion around this. The import-chrome tool does a pretty good job at converting a chrome-tracing profile capture, but something that we don't have is the idea of frames. Unfortunately, the chrome-tracing spec doesn't seem to have any mention of frames.

It does, however, mention that v-blank is recorded as an Instant event type. import-chrome currently converts these events to messages. But perhaps we could treat instant events that start with "frame" as being a frame mark?

Thoughts?

@wolfpld
Copy link
Owner

wolfpld commented Sep 1, 2022

Looks reasonable.

@wolfpld
Copy link
Owner

wolfpld commented Sep 2, 2022

Fixed by PR #459.

@wolfpld wolfpld closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants