Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImGuiColorTextEditor inside tracy namespace introduces bloat #7

Closed
cliffowen opened this issue Apr 16, 2020 · 1 comment
Closed

ImGuiColorTextEditor inside tracy namespace introduces bloat #7

cliffowen opened this issue Apr 16, 2020 · 1 comment

Comments

@cliffowen
Copy link

We are using ImGuiColorTextEditor inside our project, and so is Tracy profiler. However, Tracy has included it inside the tracy namespace (profiler). This leads to it being required twice... inside and outside the namespace so that we may use it or tracy may use it.

You can see these changes to the ImGuiColorTextEditor project in the texteditor.h and texteditor.cpp.

Requesting this 3rd party lib be outside the tracy namespace so it may be included once... To include only the standard ImGuiColorTextEditor introduces a linker error that tracy cannot find it. You would still be able to ship the version you provide, but you would not conflict with folks using a competing equivalent library.

@wolfpld
Copy link
Owner

wolfpld commented Apr 16, 2020

ImGuiColorTextEditor is no longer used on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants