Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Pokémon #12

Closed
OSwoboda opened this issue Aug 2, 2016 · 7 comments
Closed

Translate Pokémon #12

OSwoboda opened this issue Aug 2, 2016 · 7 comments

Comments

@OSwoboda
Copy link

OSwoboda commented Aug 2, 2016

I'm from Germany and need to look up the names for the Pokémon often. There is no need for other things to translate, but the names of the Pokémon.

@SuigetsuSake
Copy link

I'm from france and i agree that translations would be nice, i would gladly do the translation for french. Even though it is not a top priority feature, it would be easier to implement now than when the app will be way bigger

@wullxz
Copy link
Contributor

wullxz commented Aug 3, 2016

I'm working on it right now...

@ghost
Copy link

ghost commented Aug 3, 2016

I think that would be fantastic. We'd have to implement some sort of localization system, but i'm sure it can be done reasonably!

@wullxz
Copy link
Contributor

wullxz commented Aug 3, 2016

It's not much of a change for the pokemon names only, because it's in the PokeGOAPI.
My issue is, that I'm not a GUI person and I want it to be saved to config.json so the user doesn't have to re-set his language all the time.

@ghost
Copy link

ghost commented Aug 3, 2016

I'm not sure what you mean, are we able to set the name of a pokemon through the API, or am i misunderstanding?

@OSwoboda
Copy link
Author

OSwoboda commented Aug 4, 2016

Thanks a lot! And it was so fast implemented :D

@Wolfsblvt
Copy link
Owner

Was resolved with #35 already. Closed here.

j4ck0p3 pushed a commit to j4ck0p3/BlossomsPokemonGoManager that referenced this issue Jul 30, 2017
Updated POM to use the new API with encryption update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants