Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay on selection #104

Closed
roife opened this issue Nov 27, 2023 · 4 comments
Closed

Overlay on selection #104

roife opened this issue Nov 27, 2023 · 4 comments

Comments

@roife
Copy link
Contributor

roife commented Nov 27, 2023

Thank you for developing this plugin. The plugin is very useful, especially the functionality of 'temp-symbol.'

However, I would like to know if it's possible to highlight only the selected area when a user chooses a certain region, for example:

image

Of course, this only affects 'temp-symbol' and doesn't impact other functionalities.

@roife
Copy link
Contributor Author

roife commented Nov 27, 2023

Actually, I've already implemented this feature. I just wanted to know if this functionality would be accepted by upstream (for example, by setting an option to allow this behavior).

If possible, I'd be happy to submit my code.

@purcell
Copy link
Collaborator

purcell commented Nov 27, 2023

I expect that would be out of scope for symbol-overlay, because it only ever highlights full symbols. IIRC, changes to highlight arbitrary strings have been declined in the past.

@purcell
Copy link
Collaborator

purcell commented Nov 27, 2023

Which is to say: highlighting the region automatically would be controversial, because I imagine it immediately wouldn't work with the navigation commands, and such a thing could be trivially built if highlighting arbitrary strings were supported. Given the lack of support for merging the latter, special-case handling of the former is not likely to be merged.

@roife
Copy link
Contributor Author

roife commented Nov 27, 2023

Thank you for the explanation, I understand now. But this feature is useful for me, if it can't be merged upstream, I might consider continuing to maintain it in my fork.

@roife roife closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants