Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for shellcheck and verify generated project. #15

Merged
merged 3 commits into from Dec 10, 2021
Merged

Conversation

escaped
Copy link
Collaborator

@escaped escaped commented Dec 10, 2021

Actionlint lints our workflow. When it was integrated, we weren't aware that an accompanying script (shellcheck) is used as well if available. This PR fixes our workflows and makes sure that all workflows and project files are validated on CI.

@escaped escaped force-pushed the fix/shellcheck branch 3 times, most recently from 3eb64a3 to 4ba8304 Compare December 10, 2021 09:57
@escaped escaped changed the title fix: make shellcheck happy Support for shellcheck and verify generated project. Dec 10, 2021
@escaped escaped marked this pull request as ready for review December 10, 2021 11:07
Copy link
Collaborator

@jerry-git jerry-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🍬 🍰

@escaped escaped merged commit c67ddb8 into master Dec 10, 2021
@escaped escaped deleted the fix/shellcheck branch December 10, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants