Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autoupdate is broken due to changed GHA behaviour #18

Merged
merged 2 commits into from Jun 8, 2022

Conversation

escaped
Copy link
Collaborator

@escaped escaped commented May 25, 2022

The auto update does not work anymore. Unfortunately, the pipeline is still reported as successfully... thus we have to manually update all repositories.
Screenshot 2022-05-25 at 16 15 12

This solution is much much simpler and has not external dependency. See UnicornGlobal/has-changes-action#5 for more information.

@escaped escaped requested a review from jerry-git May 25, 2022 13:16
jerry-git
jerry-git previously approved these changes May 25, 2022
@somidad
Copy link

somidad commented May 26, 2022

@escaped I posted the solution in the referenced issue. For information, git status --porcelain | wc -l returns the number of untracked and modified files.

So if the following step checks like if: steps.changes.outputs.changed == 1, it only checks whether the number of untracked and modified files is equal to 1. So I believe, if there is no particular corner case, it should be changed != 0 or changed > 0, in general.

@escaped escaped merged commit 86c95a3 into master Jun 8, 2022
@escaped escaped deleted the fix/autoupdate branch June 8, 2022 09:35
jerry-git added a commit that referenced this pull request Jun 13, 2022
Leftover from #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants