Update actions/setup-python version
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! 馃憢 Since `actions/setup-python@v2` has some deprecation warnings, the version can be upgraded to `v4`. More info: - actions/setup-python#526 - https://github.com/joaopalmeiro/cloack/actions/runs/3629587864/jobs/6121966272
escaped
reviewed
Jan 3, 2023
There was a problem hiding this comment.
Hey, thanks a lot for your contribution. Yeah, I think this is a great one. There are a couple more places where this change should be applied to as well: https://github.com/search?q=repo%3Awoltapp%2Fwolt-python-package-cookiecutter%20actions%2Fsetup-python&type=code
Would you mind adjusting your PR and upgrade thos as well? 馃檹
|
Done, @escaped ! 馃槃 |
pexea12
approved these changes
Jan 11, 2023
|
@escaped gentle nudge to review this when you have time. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 馃憢
Since
actions/setup-python@v2has some deprecation warnings, the version can be upgraded tov4. More info: