-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulling Version Number Not Working #35
Comments
I am not able to reproduce the issue, but you are right, API is always the better solution. |
@Alamantus thanks for reporting this. This happens to me sometimes due to GitHub actually delaying the update process - not sure what causes this. Did you try logging out and in again, as the "Update" button shows only once each time you log in. |
@robiso Oh, you are correct! I was somehow still logged in when I swapped subdirectories to test. The update prompt does show up when you first log in. Sorry about that! But I do still think it is best to use the Github API, so I will work on implementing that at a more relaxed pace. 😄 |
You're awesome and thanks for confirming. Like you said, we're in no hurry and its questionable if we'll need this. 👍 A backup plan always comes in handy! Closing issue for now. |
I had an old version of WonderCMS installed while testing the version 2.1.0, and was not prompted for an upgrade. I believe we need to use the Github API to accurately get the raw files rather than using
raw.githubusercontent.com
.Here is a Stackoverflow article that makes me think this is so: https://stackoverflow.com/a/22314262
I don't know why it worked in the past and doesn't seem to be working now, but things change with APIs and file access pretty frequently with larger content hosting sites like Github, so maybe something changed recently?
I'll work on figuring the API out and get a pull request up to fix this as soon as I can.
The text was updated successfully, but these errors were encountered: