Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Clean up scene' deleting panel content #742

Closed
automaton-0 opened this issue Oct 3, 2017 · 2 comments
Closed

'Clean up scene' deleting panel content #742

automaton-0 opened this issue Oct 3, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@automaton-0
Copy link

automaton-0 commented Oct 3, 2017

Hi devs,

While working on storyboard, I went back to eariler panels in the timeline and found 3 panels had disappeared, the thumbnails are still visible but the canvas is blank.

Upon further testing, I found that the 'clean up scene' function might not be working as intented as it deletes content from panels in the timeline.

I've not been able to consistently replicate the issue, but it seems to be related to duplicating panels, here's what I did:

1. created new storyboard document.
2. created 20 panels and drew the corrosponding numbers on each pane.
3. used 'clean up scene', nothing changed.
3. duplicated panel 1 three times and amended each with 1a, 1b, 1c.
4. used 'clean up scene' and the duplicate panels were deleted altogether.
5. repeated the action but nothing was deleted the second time.
6. repeated again with other panels, sometimes with a single panel being deleted.

TEST 2
1. created one panel and drew '1' on pane.
2. quickly duplicated it and added '2' on pane.
3. repeated 7 times with numbers 1 - 7 drawn on pane.
4. used 'clean up scene', this time received an error:
Uncaught TypeError: Cannot read property of 'url' of undefined
In file C:\Program Files\Storyboarder\resources\app.asar\src\js\window\main-window.js#1289:22
5. this pop up appears for each of the duplicate panels, it appears, followed by a different pop up:
Uncaught TypeError: Cannot read property 'lineMileage' of undefined
In file: *same as before but ending in main-window.js#1238:14
6. followed by another pop up:
Uncaught you need to call 'down' first
In file: C:\Program Files\Storyboarder\resources\app.asar\src\js\sketch-pane\index.js#571:7
7. after this the application would either become unresponsive or continue to launch pop ups when clicking on the window.

System specs:
Windows 10 (10.0.14393 build 14393)
Cintiq 13HD with driver version 6.3.23-1
GPU: Gigabyte R9 Radeon 280x

UPDATE: Another test: repeated test 2 but after duplicating panels, I waited for several seconds before using 'clean up scene'. No errors this time and no panels deleted, so I think it's obvious what happened before was that the app was still in the process of saving the new panels.
However, this still doesn't account for how my original panels were deleted long after they had been drawn.

Feels like this is linked to #713 somehow... but doing the opposite???

@audionerd
Copy link
Member

audionerd commented Oct 5, 2017

Thanks for the report.

My guess is that when duplicating boards, you ran into the dreaded missing file bug (which has been fixed #708) and only became aware of it when attempting to cleanup.

I think we will have fixed this in the upcoming release (v0.13.0)

Related to #708

@audionerd audionerd self-assigned this Oct 5, 2017
@audionerd audionerd added the bug label Oct 5, 2017
@audionerd audionerd added this to the Beta 13 milestone Oct 5, 2017
@audionerd audionerd added this to IN PROGRESS in Features for RC1 Oct 5, 2017
@setpixel setpixel closed this as completed Oct 6, 2017
@setpixel setpixel moved this from IN PROGRESS to DONE in Features for RC1 Oct 6, 2017
@audionerd audionerd removed this from DONE in Features for RC1 Oct 9, 2017
@OliverGuse
Copy link

:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants