Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade electron-builder and electron-updater #858

Closed
audionerd opened this issue Oct 30, 2017 · 0 comments
Closed

Upgrade electron-builder and electron-updater #858

audionerd opened this issue Oct 30, 2017 · 0 comments

Comments

@audionerd
Copy link
Member

audionerd commented Oct 30, 2017 •
edited

To build, prefix build command with ELECTRON_BUILDER_ALLOW_UNRESOLVED_DEPENDENCIES=true

Otherwise, trying to build fails with:

Error: Unresolved node modules: webpack
    at […]./node_modules/electron-builder/src/util/packageDependencies.ts:112:19

This is due to pdfjs-dist requiring webpack as a peer dependency.

Related to electron-userland/electron-builder#2236
@audionerd audionerd added this to DONE in Features for RC1 Oct 30, 2017
@audionerd audionerd removed this from DONE in Features for RC1 Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@audionerd