New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes drop on wire issues #110
Conversation
The Pyflow documentation describes the drop on wire functionality. However, this does not work in the current version. This commit fixes the problem by making additions to the mouseReleaseEvent of the BlueprintCanvas class.
@AbdelazizSharaf001 do you mind reviewing this PR ? |
I noticed this morning that it's actually not a fix, but a new feature. My code adds the functionality Drop on Wire from nodes that are already on the canvas and are dragged onto a wire. In the video documentation Drop On Wire is shown from the nodebox onto a wire, which unfortunately does not work either. For this I have coded an actual fix (see my fork). In my fork, Drop on Wire works out of Canvas and out of Nodebox. In addition, there is now also Drop On Pin, which you can not see at all in the video documentation :) |
In my fork of AnimationFreeCAD to be precise: https://github.com/j8sr0230/AnimationFreeCAD. Just let me know if you want me to put it in the PyFlow upstream. |
Seems you are better than me @j8sr0230 |
Interesting, actually I only wanted to make a pull request regarding the drop on wire functionality. All other commits I did in my own fork of PyFlow. I didn't know that all commits are sent upstream. Is there any way to prevent this so that I only push my changes into my fork initially? |
@AbdelazizSharaf001 Thanks for rating. I have done some more research. As long as a pull request is open, all further commits in my fork are automatically merged. Of course, that was not my intention. The clean solution is to create a separate branch for each pull to control exactly what should be merged. For this reason, I am closing this pull and continuing to work in my own fork until I have enough input for a meaningful pull request. |
The Pyflow documentation describes the drop on wire functionality. However, this does not work in the current version. This commit fixes the problem by making additions to the mouseReleaseEvent of the BlueprintCanvas class.