Fix for OS X and unix command line to launch external editor. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll test it on windows today and merge. Thank you! |
|
@Kmanfi are you test it on mac? |
|
Yes, tested with latest OS X, MacBook Pro. |
|
Problem here with shlex.split is if file name will contain spaces. I believe your path to text editor does not contain them? |
|
I'll test path with spaces. |
|
Also try path without quotes at all. Content of line edit is already a string |
|
Tested on OS X. Windows? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quotes around file name in OS X comman line doesn't work.
Popen works better with list of parameters.
Found solution here.
https://docs.python.org/3.4/library/subprocess.html
17.5.1.2. Popen Constructor
This PR is not tested with Windows.