add support for most search engines #31

josStorer · 2022-12-06T05:22:17Z

Now support Google, Bing, Yahoo, DuckDuckGo, StartPage, Baidu, Kagi, Yandex, Naver, Brave, Searx, Ecosia
Have a try here: https://github.com/josStorer/chat-gpt-search-engine-extension/releases

Preview:

josStorer · 2022-12-06T05:25:00Z

related: #1 #8 #20 #21 #22 #24

wong2 · 2022-12-06T15:34:53Z

Wow thanks, I'll take a look tomorrow

mohamedmansour · 2022-12-06T20:53:32Z

src/content-script/index.mjs

+import Browser from 'webextension-polyfill'
+import {getPossibleElementByClassArray, getPossibleElementByIdArray, getPossibleElementByNameArray} from './utils.mjs'
+
+const config = {


Instead of doing it this way which will get messy and harder to maintain. Having a configuration for each search engine then it will be a single lookup instead doing it for all arrays. Easier to maintain if we split this up per search engine.

Instead of doing it this way which will get messy and harder to maintain. Having a configuration for each search engine then it will be a single lookup instead doing it for all arrays. Easier to maintain if we split this up per search engine.

agree with you, this is a 'just work' version

Much better!

kxxt · 2022-12-07T14:04:23Z

This is a review generated by ChatGPT 🤩:

This pull request appears to add support for multiple search engines to a browser extension that displays ChatGPT responses alongside search results. The extension currently only supports Google, but this pull request aims to add support for Bing, Yahoo, DuckDuckGo, StartPage, Baidu, Kagi, Yandex, Naver, Brave, Searx, and Ecosia.

One potential problem with this pull request is that it hardcodes the input element names for search boxes into the config variable. This means that if any of the search engines supported by this extension change the name of their search box input elements, the extension will no longer be able to find them and will not be able to display ChatGPT responses alongside search results.

To fix this issue, I would suggest using a more flexible approach for identifying search box input elements. One way to do this would be to use the querySelectorAll method to search for elements with the input tag and the search or query attribute, rather than hardcoding specific input element names into the config variable.

Another potential problem with this pull request is that it adds a large number of new configuration options to the config variable, which makes the code difficult to read and understand. To improve readability and make it easier to maintain the code, I would suggest moving the configuration options for each search engine into a separate object. This would make it easier to add, remove, or modify the configuration options for individual search engines without having to scroll through a long list of options.

Overall, I think this pull request has the potential to add useful functionality to the extension, but it would benefit from some changes to improve its flexibility and readability.

wong2 · 2022-12-07T14:16:12Z

@kxxt That's cool

josStorer · 2022-12-07T14:36:01Z

@wong2 are you currently working on this PR? If not, I can do some updates tomorrow to make it more flexible and readable

wong2 · 2022-12-07T14:36:42Z

@josStorer I'm not.

mohamedmansour

Much better, now hope search engines don't change layouts or selector names :-)

wong2 · 2022-12-08T06:30:36Z

Please resolve conflicts

josStorer · 2022-12-08T06:49:02Z

@wong2 resolved

jonathansampson · 2022-12-08T15:52:26Z

Nice work, @josStorer!

wong2 · 2022-12-08T15:58:44Z

src/content-script/utils.mjs

+    }
+  );
+  return element;
+}


I'd prefer using simple for...of loop for these functions

Sorry I don't know what happened when I wrote this code, it does seem like a long and incomprehensible way 😂

wong2 · 2022-12-08T16:00:52Z

src/content-script/index.mjs

+const siteNameReplaceList = [document.location.hostname, "www.", "search.", "cn."]
+const siteName = siteNameReplaceList.reduce((pre, cur) => {
+  return pre.replace(cur, "")
+}).match(/(.+?)\./)[1]


This is hard to read and understand

replace the prefix of hostname, and then get first word before the dot with regex

do you think it would be better to change the implement, or just add some comments

I think we can create a regex with Object.keys(config) and use it to match location.hostname

wong2 · 2022-12-08T16:11:13Z

src/manifest.json

+        "https://*/search*",
+        "https://duckduckgo.com/*q=*",
+        "https://*.startpage.com/sp/search*",
+        "https://*.baidu.com/s*wd=*"


I think we can change this to https://*/*?

yes, we can

josStorer · 2022-12-08T16:49:08Z

@wong2 have updated and tested, it works fine

wong2 · 2022-12-08T16:53:52Z

src/content-script/engine-match-config.mjs

+    sidebarContainerId: ["rhs"],
+    sidebarContainerClass: [],
+    appendContainerId: ["rcnt"],
+    appendContainerClass: []


maybe we can combine id and class, by using querySelector

ok, wait a minute

@wong2 finished

wong2 · 2022-12-08T17:18:53Z

thanks, I'll merge after more tests tomorrow

wong2 · 2022-12-09T11:50:17Z

I'll merge this and do some fixes myself.

ghost · 2022-12-21T07:54:46Z

大佬厉害

add support for more search engines

2e2d092

josStorer mentioned this pull request Dec 6, 2022

Adds Bing Engine support #22

Closed

support brave, searx, ecosia

bb9968a

wong2 added the search-engine-request label Dec 6, 2022

This was referenced Dec 6, 2022

Add DuckDuckGo Functionality!! #8

Closed

support startpage and duckduckgo #21

Closed

mohamedmansour reviewed Dec 6, 2022

View reviewed changes

Plutone11011 mentioned this pull request Dec 6, 2022

Add DuckDuckGO Please #45

Closed

update code style for more clear PR

c4e4708

Polydynamical mentioned this pull request Dec 7, 2022

feature request: make this also work with brave search and searx instances #1

Closed

josStorer added 3 commits December 8, 2022 11:33

resolve conflicts in PR

9a957c5

update config to make it more flexible and readable

df7b43a

update siteName for cn.bing.com

dbe6643

mohamedmansour approved these changes Dec 8, 2022

View reviewed changes

Merge branch 'main' into more_search_engines

97408b1

wong2 reviewed Dec 8, 2022

View reviewed changes

josStorer added 3 commits December 9, 2022 00:46

simplify manifest

b3a92ae

change the implement in utils.mjs for get elements

e9bd8a2

change the way to get siteName, to make it more readable

ee69cad

wong2 reviewed Dec 8, 2022

View reviewed changes

use document.querySelector to find elements

f8e8893

update for bing and ecosia

2102926

This was referenced Dec 9, 2022

Add support for Kagi #24

Closed

能添加百度、必应等引擎支持吗 #86

Closed

Merge branch 'main' into more_search_engines

2532e3b

josStorer mentioned this pull request Dec 9, 2022

其他搜索引擎界面引用chatgpt吗 #88

Closed

wong2 merged commit 24f843f into wong2:main Dec 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add support for most search engines #31

add support for most search engines #31

josStorer commented Dec 6, 2022 •

edited

josStorer commented Dec 6, 2022 •

edited

wong2 commented Dec 6, 2022

mohamedmansour Dec 6, 2022

josStorer Dec 7, 2022 •

edited

mohamedmansour Dec 8, 2022

kxxt commented Dec 7, 2022

wong2 commented Dec 7, 2022

josStorer commented Dec 7, 2022

wong2 commented Dec 7, 2022

mohamedmansour left a comment

wong2 commented Dec 8, 2022

josStorer commented Dec 8, 2022

jonathansampson commented Dec 8, 2022

wong2 Dec 8, 2022

josStorer Dec 8, 2022

wong2 Dec 8, 2022

josStorer Dec 8, 2022

wong2 Dec 8, 2022 •

edited

josStorer Dec 8, 2022

wong2 Dec 8, 2022

josStorer Dec 8, 2022

josStorer commented Dec 8, 2022 •

edited

wong2 Dec 8, 2022

josStorer Dec 8, 2022

josStorer Dec 8, 2022

wong2 commented Dec 8, 2022

wong2 commented Dec 9, 2022

ghost commented Dec 21, 2022

add support for most search engines #31

add support for most search engines #31

Conversation

josStorer commented Dec 6, 2022 • edited

josStorer commented Dec 6, 2022 • edited

wong2 commented Dec 6, 2022

Choose a reason for hiding this comment

josStorer Dec 7, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kxxt commented Dec 7, 2022

wong2 commented Dec 7, 2022

josStorer commented Dec 7, 2022

wong2 commented Dec 7, 2022

mohamedmansour left a comment

Choose a reason for hiding this comment

wong2 commented Dec 8, 2022

josStorer commented Dec 8, 2022

jonathansampson commented Dec 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wong2 Dec 8, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josStorer commented Dec 8, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wong2 commented Dec 8, 2022

wong2 commented Dec 9, 2022

ghost commented Dec 21, 2022

josStorer commented Dec 6, 2022 •

edited

josStorer commented Dec 6, 2022 •

edited

josStorer Dec 7, 2022 •

edited

wong2 Dec 8, 2022 •

edited

josStorer commented Dec 8, 2022 •

edited