-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working with project dependencies #1
Comments
I also realize that {
"phpSniffer.executablesFolder": "./vendor/bin/",
"phpSniffer.standard": "./phpcs.xml"
} |
Ok, it looks like both the above settings require absolute path. So when I changed {
"phpSniffer.executablesFolder": "/Volumes/Development/vagrant/www/eform/public_html/wp-content/plugins/wp-fsqm-pro/vendor/bin/",
"phpSniffer.standard": "/Volumes/Development/vagrant/www/eform/public_html/wp-content/plugins/wp-fsqm-pro/phpcs.xml"
} It started working. Maybe you can consider this a feature request? I will try to add this in a fork and get back to you. |
I think passing the workspace folder as the CWD to the command execution might work. |
Yes, that should definitely do. If someone is passing in absolute path, then the CWD wouldn't matter anyway. |
I'm having the same problem, but my php is running inside a docker container, I have a #!/bin/bash
docker exec \
-it \
-u $(id -u) \
-w "$PWD" \
php7 \
php "$@" |
Are you running the latest version of the extension? |
Yes, I'm using the latest version of the extension. "scripts": {
"lint": "phpcs",
"lint:fix": "phpcbf"
} I just need to run |
Hello,
First of all, thank you very much for this extension. I really appreciate the time and effort you've put behind this. Kudos.
So I am trying to switch over from vscode-phpcs extension. I have phpcs installed as my project dependency. My
composer.json
is something like thisAnd I have a
phpcs.xml
file in the root of my project/repo.Within vscode preference, I have set the following to tell the extension about
phpcs
path.PS: I do have the trailing slash added, but still nothing really happens.
But nothing really happens. I am not sure how the extension is supposed to work. I assumed, it would show lint errors when I open a file? I can confirm
phpcs
itself works because if I runIt works just fine. Am I missing something? Please let me know.
The text was updated successfully, but these errors were encountered: