Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asNavFor navigates when using touch option and swiping #1682

Open
RwwL opened this issue Nov 17, 2017 · 0 comments · May be fixed by #1688
Open

asNavFor navigates when using touch option and swiping #1682

RwwL opened this issue Nov 17, 2017 · 0 comments · May be fixed by #1688

Comments

@RwwL
Copy link
Contributor

RwwL commented Nov 17, 2017

steps to repro:

  • create an asNavFor setup with a lot of thumbnails (enough that it'll be scrollable)
  • use the touch option on that asNavFor slider
  • swipe the navigating slider to reveal more thumbs

expected behavior (debatable UX question, sure, but this is coming from multiple customer complaints and it feels wonky to everyone I've shown it to):

  • thumbnail gallery advances based on your swipe but main slider doesn't change

actual behavior:

  • main slider advances to whatever thumbnail you touched when you started the swipe

We've worked around this in our company's fork by adding a "swiping" flag during swipes and checking for it in the asNav method; it's been pretty well-tested across browsers. Will submit a pull request later with this tweak in case you want it upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment