Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Research the best way to detect when MySQL is out of temporary space #650

Closed
jonathansadowski opened this issue Jan 11, 2021 · 2 comments
Labels
type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@jonathansadowski
Copy link
Contributor

There's a suggestion that #634 could be solved if we added a check to see if MySQL is out of temporary space.

Desired outcome of this spike: proposal for a way to detect MySQL has exhausted its temporary space and an understanding of whether or not we could apply that detection toward solving #634.

@jonathansadowski jonathansadowski added the type: task The issue is an internally driven task (e.g. from another A8c team). label Jan 11, 2021
@barryhughes
Copy link
Member

Some relevant docs/articles:

Possibly we can detect this specific error (whether that's through exception handling, or by inspecting $wpdb->last_error, or some other approach) and then we could perhaps put a temporary pause on further queue processing (as proposed here).

However, we also recently added an extra set of safety checks to prevent the AS-specific problem of actions being processed ahead-of-time. With that in place, I'm wondering if there is still value in doing more research here, or if this can be closed.

cc @jonathansadowski @vedanshujain

@barryhughes
Copy link
Member

Closing, since #634 was merged some time back and should avoid the core issue of actions being inadvertently processed ahead of schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

No branches or pull requests

2 participants