Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.slider hardcoded in plugin #49

Closed
jjroelofs opened this issue Jan 6, 2012 · 3 comments
Closed

.slider hardcoded in plugin #49

jjroelofs opened this issue Jan 6, 2012 · 3 comments

Comments

@jjroelofs
Copy link

I don't think it's good that the .slides class is hardcoded in. Sometimes the ul that contains slides may be coming from a CMS or external system and you can't control the markup.

Other times you may have a list of slides that already has a semantic class name and adding a .slides class would reduce the semantic meaning of your document. If I could pass in ".tweets" as an argument to find the slides that would be better.

Or, if we're still keeping the ul parent element hardcoded into the plugin, it's also an option to just select the first-child

    tag starting from the element on which Flexslider is invoked.

@stephenwil
Copy link

We modified the plugin to take in classes via options

@stephenwil
Copy link

See my fork to override default HTML scaffold

@tylernotfound
Copy link
Contributor

I'll definitely have something in place for this in v2.0, and will look into your implementation. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants