Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WC 6.5 to 6.7 compatibility issue: Modal header border bottom is missing #1583

Closed
ecgan opened this issue Jul 4, 2022 · 2 comments
Closed
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug.

Comments

@ecgan
Copy link
Member

ecgan commented Jul 4, 2022

Describe the bug:

I was doing compatibility testing with WooCommerce 6.7.0-beta.2 in #1577, and I noticed that the Modal component is missing the border / separator between the modal header title and modal body content. The border is missing because of some CSS from the WooCommerce core:

image

I tested previous WC versions and found out that the issue happens in WC 6.6.0 and 6.5.0 too.

In WC 6.4.0, the modal component shows up fine, with a border / separator between the modal header title and modal content:

image

Steps to reproduce:

  1. Use WC 6.7.0-beta.2, 6.6.0 or 6.5.0.
  2. Open a modal in Google Listings and Ads, such as the Edit Free Listings modal shown above.

Expected behavior:

There should be a border between the modal header and modal body, similar to @wordpress/components modal: https://wordpress.github.io/gutenberg/?path=/story/components-modal--default

image

Actual behavior:

There is no border between the modal header and modal body.

Additional details:

I have also created an issue in WooCommerce repo: woocommerce/woocommerce#33720.

@ecgan ecgan added the type: bug The issue is a confirmed bug. label Jul 4, 2022
@jconroy jconroy added the priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. label Jul 5, 2022
@puntope puntope assigned puntope and unassigned puntope Jul 8, 2022
@wyter
Copy link

wyter commented Aug 19, 2022

Tested on WooCommerce 6.8.0 and could still replicate:
Free listings

However, following this comment, we can wait to see if version 6.9.0 fixes the issue and then close here.

@mikkamp
Copy link
Contributor

mikkamp commented Nov 15, 2022

We are at WooCommerce 7.1 now and the WooCommerce issue has been resolved, with the CSS for a 0 border no longer being added: woocommerce/woocommerce#33807

However when looking back at the expected behaviour I see that the WP component now behaves differently: https://wordpress.github.io/gutenberg/?path=/story/components-modal--default

image

image

Based on this PR, it seems it's an intended design choice: WordPress/gutenberg#40781
Closing this issue as there isn't any further action to take.

@mikkamp mikkamp closed this as completed Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

5 participants