Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rare-ish Javascript error with Yoast SEO breaks colour picker #15

Open
hlashbrooke opened this issue Nov 25, 2015 · 2 comments
Open

Rare-ish Javascript error with Yoast SEO breaks colour picker #15

hlashbrooke opened this issue Nov 25, 2015 · 2 comments
Assignees
@mendezcode
Labels
question
Milestone
1.1.1

Comments

@hlashbrooke
Copy link

In pre-v3 Yoast SEO there was a filter to disable the SEO meta box on the post edit screen. If you use the same filter in v3+ of Yoast SEO then it disables the meta box, but the Javascript still runs, which results in this error in the console:

screen shot 2015-11-25 at 10 05 18 am

That subsequently breaks any other JS on the page, including the colour picker in Icons for Features.
@jeffikus jeffikus self-assigned this Dec 14, 2015
@jeffikus
Copy link
Member

Cool, will test again in the new year. Thanks for posting here.

@jeffikus jeffikus added this to the 1.1.1 milestone Dec 23, 2016
@jeffikus
Copy link
Member

@mendezcode please confirm, if it has been resolved please close the issue.

@jeffikus jeffikus removed their assignment Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mendezcode mendezcode

Labels
question
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
3 participants
@jeffikus @hlashbrooke @mendezcode