Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Use stock_status sort order by default in Stock table #1340

Merged

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Jan 17, 2019

Follow-up of #1335.

Make Stock table to use stock_status as the default sort value instead of stock_quantity.

Detailed test instructions:

  • Go to the Stock report.
  • Verify it sorts stock items by stock_status by default.

@Aljullu Aljullu added [Status] Needs Review focus: analytics Issues about Analytics/Reports labels Jan 17, 2019
@Aljullu Aljullu self-assigned this Jan 17, 2019
@Aljullu Aljullu requested a review from joshuatf January 17, 2019 11:46
Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well 👍

@joshuatf joshuatf merged commit aec9968 into update/allow-stock-status-sort Jan 18, 2019
@joshuatf joshuatf added this to 🥋Sprint 11 Done in Isotope via automation Jan 18, 2019
@joshuatf joshuatf deleted the update/stock-table-sort-stock_status branch January 18, 2019 06:41
joshuatf added a commit that referenced this pull request Jan 21, 2019
* REST API: Allow sorting by stock_status in stocks endpoint

* Set stock_status as default orderby

* Sort by both stock status and quantity in meta query

* Use stock_status sort order by default in Stock table (#1340)

* Reverse stock quantity order when sorting by stock status
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: analytics Issues about Analytics/Reports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants