Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Notices: Cannot call 'classList' of undefined #2366

Closed
psealock opened this issue Jun 5, 2019 · 0 comments · Fixed by #2378
Closed

Notices: Cannot call 'classList' of undefined #2366

psealock opened this issue Jun 5, 2019 · 0 comments · Fixed by #2378
Assignees
@Aljullu
Labels
type: bug The issue is a confirmed bug.

Comments

@psealock
Copy link
Collaborator

psealock commented Jun 5, 2019

Describe the bug

Some plugins remove the wp__notice-list element to hide notifications. We should check to make sure the element exists before manipulating its class list.

woocommerce-admin/client/header/activity-panel/wordpress-notices.js

Line 71 in 9526e0b

const notices = document.getElementById( 'wp__notice-list' );

To Reproduce

Without a plugin such as this one, https://wordpress.org/plugins/hide-plugin-updates-notifications/#description, I'm not sure how to reproduce.
@psealock psealock added the type: bug The issue is a confirmed bug. label Jun 5, 2019
@psealock psealock added this to wc-admin Backlog 🔙 in Isotope via automation Jun 5, 2019
@Aljullu Aljullu self-assigned this Jun 5, 2019
@timmyc timmyc moved this from wc-admin Backlog 🔙 to 📊 wc-admin Sprint Backlog in Isotope Jun 7, 2019
@Aljullu Aljullu mentioned this issue Jun 9, 2019
Merged
Isotope automation moved this from 📊 wc-admin Sprint Backlog to 🐀 May 14 - 30 Done Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Aljullu Aljullu

Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
2 participants
@psealock @Aljullu