Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Charts: Update styles per different time periods #382

Closed
2 tasks done
LevinMedia opened this issue Sep 10, 2018 · 5 comments
Closed
2 tasks done

Charts: Update styles per different time periods #382

LevinMedia opened this issue Sep 10, 2018 · 5 comments
Assignees
Labels
focus: analytics Issues about Analytics/Reports needs: design The issue requires design input/work from a designer.

Comments

@LevinMedia
Copy link
Contributor

LevinMedia commented Sep 10, 2018

Line Chart

  • When there are > 50 data points on the X axis, remove the dots from the lines, and make the line weight 2px

X-Axis ticks

  • Limit the number of X-Axis ticks that appear at any given time per the breakpoints section of p6riRB-3jq-p2

Secondary X-Axis labels

  • [*] Add additional secondary labels as required - eg:

screen shot 2018-09-10 at 8 38 56 am

screen shot 2018-09-10 at 9 05 16 am

@LevinMedia LevinMedia added focus: analytics Issues about Analytics/Reports needs: design The issue requires design input/work from a designer. labels Sep 10, 2018
@greenafrican greenafrican mentioned this issue Sep 10, 2018
27 tasks
@timmyc timmyc added this to Project Backlog 🔙 in Isotope Sep 10, 2018
@greenafrican
Copy link
Contributor

@LevinMedia with regards to:

X-Axis ticks

Thinking about this more and I'm not sure it will be possible to achieve exactly what we had planned to here. The best way to explain this is to look at an example of a day series:
screenshot 2018-09-11 15 29 49

If this needed to be rendered into the compact view, with max-ticks = 7, then we'd end up with fractions of a day. I think the best we can do each time we want to reduce the number of ticks is first to remove ±half of them, then remove half of those, etc. etc. I could continue to do this until the number of ticks is less than the number mentioned in your designs?

@LevinMedia
Copy link
Contributor Author

LevinMedia commented Sep 11, 2018

@greenafrican That's a great example - And I think that is probably the best way to address it.

A little more insight: I was thinking about "max ticks" as an absolute maximum per screen size - meaning it's not always necessary to use the max. So in the case above, following your suggestion you could cut the number in half to end up with 5 ticks, illustrated below:

screen shot 2018-09-11 at 7 20 55 am

In this case the chart still begins on August 1, however the first tick is on the second, and the sub label (Aug 2018) is placed accordingly.

@greenafrican
Copy link
Contributor

Seems as though there is some debate about this and that our approach is a common approach to reduce tick counts - d3/d3-array#61 (comment)

@timmyc timmyc moved this from Project Backlog 🔙 to ✌️Sprint 4 Backlog in Isotope Sep 13, 2018
@timmyc timmyc moved this from ✌️Sprint 4 Backlog to 🤙Sprint 5 Backlog in Isotope Oct 8, 2018
@Aljullu Aljullu self-assigned this Oct 15, 2018
@Aljullu
Copy link
Contributor

Aljullu commented Oct 16, 2018

@LevinMedia

Add additional secondary labels as required

Isn't that already implemented or am I misunderstanding it?

for longer time periods, make the primary x-axis ticks months, and only use the year as a secondary label

That's being implemented in #525. Feel free to take a look at that PR. 🙂

@Aljullu
Copy link
Contributor

Aljullu commented Oct 18, 2018

Closing it after speaking with @LevinMedia in Slack.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: analytics Issues about Analytics/Reports needs: design The issue requires design input/work from a designer.
Projects
None yet
Development

No branches or pull requests

3 participants