Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Adjust the image of the Discount banner with image pattern #10104

Closed
Tracked by #42339
nielslange opened this issue Jul 5, 2023 · 0 comments · Fixed by #10108
Closed
Tracked by #42339

Adjust the image of the Discount banner with image pattern #10104

nielslange opened this issue Jul 5, 2023 · 0 comments · Fixed by #10108
Labels
focus: global styles Issues that involve styles/css/layout structure. focus: patterns WooCommerce patterns type: bug The issue/PR concerns a confirmed bug.

Comments

@nielslange
Copy link
Member

Note

In #9957, we introduced the Discount banner with image pattern. While testing the WooCommerce Blocks 10.6.0 release, I noticed that the image is overlapping in the mobile preview in the page editor.

Expected behaviour

I expect the image not to overlap in the mobile view in the page editor.

Current behaviour

The image is overlapping in the mobile view in the page editor.

Steps to reproduce

  1. Create a test page.
  2. Add the Discount banner with image pattern to it.
  3. Switch the preview to Mobile.
  4. See that the image is overlapping in the page editor.

Note
This problem only appears in the page editor, not in the frontend. And it only appears in the mobile preview. In the tablet and desktop perview, the image does not overlap.

Proposed solution

I propose adjusting the image so that it no longer overlaps in the mobile preview in the page editor.

Screenshot

Screenshot 2023-07-05 at 15 56 17

cc: @albarin (internal thread: p1688568877785369/1688565263.597279-slack-C02UBB1EPEF)

@nielslange nielslange added type: bug The issue/PR concerns a confirmed bug. focus: global styles Issues that involve styles/css/layout structure. focus: patterns WooCommerce patterns labels Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: global styles Issues that involve styles/css/layout structure. focus: patterns WooCommerce patterns type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant