Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Style "Apply globally" button incorrectly visible when WooCommerce is active #10377

Closed
5 tasks done
laurelfulford opened this issue Jul 24, 2023 · 3 comments
Closed
5 tasks done
Labels
type: bug The issue/PR concerns a confirmed bug.

Comments

@laurelfulford
Copy link

laurelfulford commented Jul 24, 2023

Prerequisites

  • I have carried out troubleshooting steps and I believe I have found a bug.
  • I have searched for similar bugs in both open and closed issues and cannot find a duplicate.

Describe the bug

In WordPress 6.3, an option to apply a block's style globally was included in the advanced panel, but only in the Site Editor. Edited to add: This looks like it's also happening in 6.2.2; I missed it when I first discovered this issue.

For some reason, this button also appears when you're in the post/page editor when WooCommerce is active, including in classic themes. It doesn't appear to work there at all.

I think this is related to woocommerce/woocommerce#39124, but not the same issue -- it looks like the button's 100% width is not included when it's displaying on posts/pages, likely because it's not supposed to be there.

Expected behavior

That the "Apply Globally" button would not appear at all in the regular post/page editor, and would only appear for blocks in the Site Editor.

Actual behavior

The "Apply Globally" button is always appearing in the Advanced panel for blocks in the post/page editor when WooCommerce is active.

Steps to reproduce

  1. Start with a site running WordPress 6.3 RC 1, and a default theme like Twenty Twenty Three, and no plugins (unless you're using the WordPress Beta testing plugin, which I did!). Edited to remove 6.3 RC 1 requirement.
  2. Create a new page, and add a paragraph to the editor.
  3. Open the Advanced panel, and note there is no "Apply Globally" button.
  4. Install and activate WooCommerce.
  5. Return to your new page, click on your paragraph and open the Advanced panel; note the "Apply Globally" button is now displaying:

image

WordPress Environment

WordPress Environment

WordPress address (URL): https://everyday-elk.jurassic.ninja
Site address (URL): https://everyday-elk.jurassic.ninja
WC Version: 7.9.0
REST API Version: ✔ 7.9.0
WC Blocks Version: ✔ 10.4.6
Action Scheduler Version: ✔ 3.6.1
Log Directory Writable: ✔
WP Version: 6.3-RC1
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
External object cache: –

Server Environment

Server Info: Apache/2.4.57 (Unix) OpenSSL/1.0.2g
PHP Version: 8.0.29
PHP Post Max Size: 1 GB
PHP Time Limit: 30
PHP Max Input Vars: 5000
cURL Version: 7.47.0
OpenSSL/1.0.2g

SUHOSIN Installed: –
MySQL Version: 5.7.33-0ubuntu0.16.04.1-log
Max Upload Size: 512 MB
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
GZip: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Database

WC Database Version: 7.9.0
WC Database Prefix: wp_
Total Database Size: 5.93MB
Database Data Size: 4.46MB
Database Index Size: 1.47MB
wp_woocommerce_sessions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_order_itemmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_woocommerce_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_actionscheduler_actions: Data: 0.02MB + Index: 0.11MB + Engine InnoDB
wp_actionscheduler_claims: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_actionscheduler_groups: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_actionscheduler_logs: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_comments: Data: 0.02MB + Index: 0.09MB + Engine InnoDB
wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_options: Data: 3.47MB + Index: 0.06MB + Engine InnoDB
wp_postmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_posts: Data: 0.03MB + Index: 0.06MB + Engine InnoDB
wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_usermeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB
wp_wc_admin_notes: Data: 0.06MB + Index: 0.00MB + Engine InnoDB
wp_wc_admin_note_actions: Data: 0.06MB + Index: 0.02MB + Engine InnoDB
wp_wc_category_lookup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_wc_customer_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_download_log: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_order_coupon_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_order_product_lookup: Data: 0.02MB + Index: 0.06MB + Engine InnoDB
wp_wc_order_stats: Data: 0.02MB + Index: 0.05MB + Engine InnoDB
wp_wc_order_tax_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB
wp_wc_product_attributes_lookup: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wc_product_download_directories: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wc_product_meta_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB
wp_wc_rate_limits: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wc_reserved_stock: Data: 0.02MB + Index: 0.00MB + Engine InnoDB
wp_wc_tax_rate_classes: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
wp_wc_webhooks: Data: 0.02MB + Index: 0.02MB + Engine InnoDB

Post Type Counts

attachment: 1
page: 11
post: 2
revision: 1
wp_global_styles: 1
wp_navigation: 1

Security

Secure connection (HTTPS): ✔
Hide errors from visitors: ❌Error messages should not be shown to visitors.

Active Plugins (3)

Companion Plugin: by Osk – 1.29
WooCommerce: by Automattic – 7.9.0
WordPress Beta Tester: by WordPress Upgrade/Install Team – 3.5.2

Inactive Plugins (4)

Akismet Anti-Spam: Spam Protection: by Automattic - Anti Spam Team – 5.2
Gutenberg: by Gutenberg Team – 16.2.1
Hello Dolly: by Matt Mullenweg – 1.7.2
Jetpack: by Automattic – 12.3

Settings

API Enabled: –
Force SSL: –
Currency: USD ($)
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Number of Decimals: 2
Taxonomies: Product Types: external (external)
grouped (grouped)
simple (simple)
variable (variable)

Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog)
exclude-from-search (exclude-from-search)
featured (featured)
outofstock (outofstock)
rated-1 (rated-1)
rated-2 (rated-2)
rated-3 (rated-3)
rated-4 (rated-4)
rated-5 (rated-5)

Connected to WooCommerce.com: –
Enforce Approved Product Download Directories: ✔
HPOS feature screen enabled: –
HPOS feature enabled: –
Order datastore: WC_Order_Data_Store_CPT
HPOS data sync enabled: –

WC Pages

Shop base: woocommerce/woocommerce#14 - /shop/
Cart: woocommerce/woocommerce#15 - /cart/
Checkout: woocommerce/woocommerce#16 - /checkout/
My account: woocommerce/woocommerce#17 - /my-account/
Terms and conditions: ❌ Page not set

Theme

Name: Twenty Twenty-Three
Version: 1.1
Author URL: https://wordpress.org
Child Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme
WooCommerce Support: ✔

Templates

Overrides: –

Admin

Enabled Features: activity-panels
analytics
product-block-editor
coupons
core-profiler
customer-effort-score-tracks
import-products-task
experimental-fashion-sample-products
shipping-smart-defaults
shipping-setting-tour
homescreen
marketing
mobile-app-banner
navigation
onboarding
onboarding-tasks
remote-inbox-notifications
remote-free-extensions
payment-gateway-suggestions
shipping-label-banner
subscriptions
store-alerts
transient-notices
woo-mobile-welcome
wc-pay-promotion
wc-pay-welcome-page

Disabled Features: minified-js
new-product-management-experience
product-variation-management
settings
async-product-editor-category-field

Daily Cron: ✔ Next scheduled: 2023-07-25 23:05:52 +00:00
Options: ✔
Notes: 64
Onboarding: -

Action Scheduler

Complete: 2
Oldest: 2023-07-24 23:14:27 +0000
Newest: 2023-07-24 23:14:27 +0000

Pending: 2
Oldest: 2023-07-24 23:15:33 +0000
Newest: 2023-07-25 23:14:27 +0000

Status report information

Generated at: 2023-07-24 23:14:55 +00:00

Isolating the problem

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.
@laurelfulford
Copy link
Author

This looks like it's actually happening in WP 6.2.2 as well; I noticed it while testing the 6.3 RC1, but I should have tested the current release as well 🤦‍♀️ I'll update the issue title to reflect that.

@laurelfulford laurelfulford changed the title WordPress 6.3 RC1: Style "Apply globally" button incorrectly visible when WooCommerce is active Style "Apply globally" button incorrectly visible when WooCommerce is active Jul 26, 2023
@rrennick
Copy link

@laurelfulford Thanks for reporting the issue. The blocks/FSE functionality is maintained in a separate repository. I'll transfer the issue to be addressed there.

@gigitux
Copy link
Contributor

gigitux commented Aug 1, 2023

Hi @laurelfulford,
thanks for opening this issue!
This issue isn't replicable anymore with WooCommerce Core 8.0. Since that it isn't a huge issue and the WooCommerce Core 8.0 will be released on 8th August, I'm closing this issue.

If you believe it is crucial to address this concern in a patch release for WooCommerce Core 7.9, kindly let us know by reopening the issue.

@gigitux gigitux closed this as completed Aug 1, 2023
@gigitux gigitux reopened this Aug 1, 2023
@gigitux gigitux added type: bug The issue/PR concerns a confirmed bug. and removed status: awaiting triage labels Aug 1, 2023
@gigitux gigitux closed this as completed Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

No branches or pull requests

4 participants