This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Reviews blocks: rating has role="img" but missing aria-label #1675
Labels
block-type: reviews
Issues related to all of the reviews related blocks.
focus: accessibility
The issue/PR is related to accessibility.
type: bug
The issue/PR concerns a confirmed bug.
type: good first issue
The issue is a good candidate for the first community contribution/for a newcomer to the team.
Ratings shown in the reviews blocks are not accessible. They have
role="img"
but are missing anaria-label
prop to define them:https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/master/assets/js/base/components/review-list-item/index.js#L126
Instead of directly solving it there, I think it would make more sense to reuse the logic from
atomic/components/product/rating/index.js
, which was made accessible in #1656 and has exactly the same markup (only class names differ).The text was updated successfully, but these errors were encountered: