Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product/Category Controls: wrong aria-expanded attribute used for role="menuitemradio" #1684

Closed
Aljullu opened this issue Jan 30, 2020 · 5 comments · Fixed by #4100
Closed

Product/Category Controls: wrong aria-expanded attribute used for role="menuitemradio" #1684

Aljullu opened this issue Jan 30, 2020 · 5 comments · Fixed by #4100
Labels
focus: accessibility The issue/PR is related to accessibility. status: stale Stale issues and PRs have had no updates for 60 days. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Jan 30, 2020

imatge

To Reproduce

  1. Create a post with a Featured Product block.
  2. Expand a product with variations.
  3. Run an Axe audit and notice there is an error: Elements must only use allowed ARIA attributes.

That's because the expanded item uses role="menuitemradio" and it has an aria-expanded attribute, which is not a valid combination:

https://www.w3.org/TR/wai-aria-1.1/#aria-expanded

https://www.w3.org/TR/wai-aria-1.1/#menuitemradio
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. focus: accessibility The issue/PR is related to accessibility. labels Jan 30, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

######Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 17, 2020
@nerrad nerrad added type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. and removed status: stale Stale issues and PRs have had no updates for 60 days. labels Jan 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 7, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 10, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label May 12, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label May 14, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 15, 2021
@Aljullu Aljullu mentioned this issue Jul 15, 2021
Merged
2 tasks
@Aljullu
Copy link
Contributor Author

Aljullu commented Jul 15, 2021 •
edited

This was fixed with #4100.

@Aljullu Aljullu closed this as completed Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
focus: accessibility The issue/PR is related to accessibility. status: stale Stale issues and PRs have had no updates for 60 days. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update @woocommerce/components woocommerce/woocommerce-blocks
2 participants
@nerrad @Aljullu