Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Migrate CountryInput and StateInput to ComboboxControl #1752

Closed
Aljullu opened this issue Feb 17, 2020 · 6 comments · Fixed by #4369
Closed

Migrate CountryInput and StateInput to ComboboxControl #1752

Aljullu opened this issue Feb 17, 2020 · 6 comments · Fixed by #4369
Assignees
@mikejolley
Labels
focus: components Work that introduces new or updates existing components. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Feb 17, 2020

Follow-up of #1574 and #1575.

In the legacy country and state controls, you could write the country name in an input field inside the select so it filtered the available options:

imatge

We would like the same for the CountryInput and StateInput components. In order to do that, we should migrate from the CustomSelectControl to the ComboboxControl that might be introduced in Gutenberg: WordPress/gutenberg#19657.
@Aljullu Aljullu added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Feb 17, 2020
@Aljullu Aljullu added this to the Future Release milestone Feb 17, 2020
@Aljullu Aljullu mentioned this issue Feb 17, 2020
Closed
4 tasks
@Aljullu Aljullu added the focus: components Work that introduces new or updates existing components. label Feb 17, 2020
@Aljullu Aljullu mentioned this issue Feb 17, 2020
Closed
3 tasks
@Aljullu Aljullu changed the title Migrate CountryInput and StateInput to ComboboxControl. Migrate CountryInput and StateInput to ComboboxControl Feb 17, 2020
@nerrad nerrad removed this from the Future Release milestone May 1, 2020
@nerrad nerrad mentioned this issue May 12, 2020
Closed
@haszari
Copy link
Member

haszari commented Aug 27, 2020

ComboBoxControl has shipped / merged, but may not be available in the package yet: WordPress/gutenberg#24443

@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

######Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 17, 2020
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jan 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 7, 2021
@nerrad
Copy link
Contributor

nerrad commented Mar 10, 2021

@Aljullu should the description or the title of this issue be changed to reflect the work you submitted to Gutenberg around related needs we have (I think it was a different component you ended up working on)?

@Aljullu
Copy link
Contributor Author

Aljullu commented Mar 11, 2021

I think it was a different component you ended up working on

@nerrad Correct, I worked on FormTokenField, the PR can be found here: WordPress/gutenberg#29110. The idea was to mimic the behavior of our DropdownSelector component (used in the Attribute Filter block) in Gutenberg's FormTokenField. That would allow us to eventually replace DropdownSelector with FormTokenField (#3762).

Having said that, I'm not sure FormTokenField is the best fit for CountryInput and StateInput. FormTokenField works best when multiple values are allowed, while ComboboxControl seems to be better suited when only a single option can be selected like in this case.

@github-actions github-actions bot removed the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 12, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label May 12, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label May 14, 2021
@mikejolley mikejolley self-assigned this Jun 17, 2021
@mikejolley mikejolley mentioned this issue Jun 18, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikejolley mikejolley

Labels
focus: components Work that introduces new or updates existing components. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from Select to Combobox for Country and State Inputs woocommerce/woocommerce-blocks
4 participants
@mikejolley @nerrad @Aljullu @haszari