Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

All Products in TwentyTwenty: on sale badge is not correctly positioned #2537

Closed
Aljullu opened this issue May 22, 2020 · 2 comments · Fixed by #2573
Closed

All Products in TwentyTwenty: on sale badge is not correctly positioned #2537

Aljullu opened this issue May 22, 2020 · 2 comments · Fixed by #2573
Assignees
@Aljullu
Labels
type: bug The issue/PR concerns a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented May 22, 2020

To Reproduce

  1. Add an All Products block.
  2. Add a Sale badge below the title.
  3. Notice it's right aligned in the editor.
  4. Open the page in the frontend and notice the sale badge is rendered on the top-right corner of the image.

Screenshots
imatge
@Aljullu Aljullu added the type: bug The issue/PR concerns a confirmed bug. label May 22, 2020
@Aljullu Aljullu assigned Aljullu and unassigned Aljullu May 22, 2020
@Aljullu Aljullu mentioned this issue May 27, 2020
Merged
@haszari
Copy link
Member

haszari commented May 27, 2020

I'm thinking the sale badge should always be positioned top-right, overlaying the image. Am I missing something?

@haszari
Copy link
Member

haszari commented May 27, 2020

DOh! I see, there's an option for an extra sale badge? I had no idea!

Figured it out, it's a nested block, now I understand the issue :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Aljullu Aljullu

Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes to Twenty Twenty product grid styles woocommerce/woocommerce-blocks
2 participants
@Aljullu @haszari