Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix payment icon layout issue with Twenty Twenty theme (non-mobile layout) #2669

Closed
nerrad opened this issue Jun 8, 2020 · 1 comment · Fixed by #2968
Closed

Fix payment icon layout issue with Twenty Twenty theme (non-mobile layout) #2669

nerrad opened this issue Jun 8, 2020 · 1 comment · Fixed by #2968
Assignees
Labels
block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.

Comments

@nerrad
Copy link
Contributor

nerrad commented Jun 8, 2020

While testing 2.7.0, I noticed that with Twenty Twenty, the payment method icons for payment methods are incorrectly positioned:

Image 2020-06-08 at 3.33.05 PM.png

They should be on the same line as the text content. Since they are at least left aligned, this isn't a huge issue but I think it would still be good to be consistent across themes for this.

@nerrad nerrad added focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug. block: checkout Issues related to the checkout block. labels Jun 8, 2020
@nerrad nerrad mentioned this issue Jun 8, 2020
11 tasks
@haszari
Copy link
Member

haszari commented Jul 30, 2020

Related: based on this comment from @LevinMedia, we are moving away from having a generic icons on payment methods; icons should be used for recognisable payment method brands only (example: PayPal).

With that in mind, we can simply remove the cheque icon and the generic CC icon (from Stripe Credit Card), which will also "fix" this theme problem. Should be a nice clean PR :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants