Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Storefront child themes issues with Cart and Checkout blocks #3110

Closed
Aljullu opened this issue Sep 3, 2020 · 4 comments
Closed

Storefront child themes issues with Cart and Checkout blocks #3110

Aljullu opened this issue Sep 3, 2020 · 4 comments
Assignees
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Sep 3, 2020

I tested all themes listed in the Storefront Themes category in WooCommerce.com with the Cart and Checkout blocks. Below is a list of issues I detected. Notice some of this issues might be in WC Blocks, some others in Storefront and some others in the child theme. However, I'm listing all of them here so we can investigate it further and open issues in the relevant repos.

I think, some of the themes listed in that page are not child themes of Storefront. So in the list below I split them between the ones that are Storefront child themes (they have some minor issues) and other themes (the experience is mostly broken).

Storefront child themes

Arcade

(I couldn't find any issue)

Bistro

(I couldn't find any issue)

Bookshop

  • Panel titles and selects have a green background.
    imatge

Boutique

(I couldn't find any issue)

Deli

  • Order summary quantity badge is not readable.
    imatge
  • Text input and button don't have the same height. (Similar issue is affecting Block Shop)
    imatge
  • Proceed to Checkout button in Cart has a weird brown background. (Similar issue is affecting Arcade, Block Shop and ToyShop)
    imatge

Galleria

  • Panel titles have a border on hover that causes the content to jump.
    Peek 2020-09-03 12-04

Homestore

  • Quantity input overflows in mobile.
    imatge

Hotel

  • Proceed to Checkout button has no background/border.
    imatge
  • Cart: there is no padding between table contents and border.
    imatge

Outlet

  • Buttons are not legible.
    imatge

Petshop

(I couldn't find any issue)

Pharmacy

  • Notices overflow page title.
    imatge

ProShop

  • Checkout: Card icons overflow checkbox label. (This issue is happening in several other themes)
    imatge

Stationery

(I couldn't find any issue)

ToyShop

  • Cart summary and Checkout order summary overflow the available space in narrow viewports.
    imatge

Other themes

Artisan and Threads

(Both themes have very similar issues, so listing them together):

  • Cart and Checkout: content breaks in two rows. (Fix Cart & Checkout sidebar layout broken in some themes #3111)
    imatge

  • Select label is not inline.
    imatge

  • Coupon chips are too big.
    imatge

  • Inputs and checkboxes are too big.
    imatge

  • Coupon code input and button are not aligned.
    imatge

  • Threads: cart table has a background.
    imatge

  • Threads: step number breaks in a separate line from number.
    imatge

  • There are some bugs in the checkout page when hovering over different elements.
    Artisan

  • Wrong alignment on the "Proceed to checkout" button
    Frame 157

  • Wrong alignment between the radio buttons and the payment titles.
    Frame 162

  • Wrong alignment in the checkout form.
    Frame 163

Block Shop

  • Payment methods section layout is broken.
    imatge
  • Proceed to Checkout button is not visible.
    imatge
  • Product image has underground.
    imatge
  • No margin between product name and badges.
    imatge
  • Form fields are broken in several lines.
    imatge
  • Wrong alignment on the "Apply coupon" button.
    Frame 171

Fifth Avenue

  • Accessibility texts are visible in prices.
    imatge
  • 'Add a note to your order' is not vertically aligned.
    imatge

Matthew

  • CSS is not loading at all.
    imatge

  • Check icon is not legible.
    Frame 212

We should change it to white.

  • Wrong alignment on the product picture and the price.
    Frame 179
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. focus: global styles Issues that involve styles/css/layout structure. labels Sep 3, 2020
@Aljullu Aljullu added block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Sep 3, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Remove the stale label or post a comment, otherwise it will be closed in 10 days.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 12, 2020
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 15, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 15, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 16, 2021
@ghost
Copy link

ghost commented Feb 23, 2021

Update: I've added some new issues to the "other themes" category.

@nerrad nerrad self-assigned this Feb 28, 2021
@nerrad
Copy link
Contributor

nerrad commented Mar 21, 2021

I'm going to close this because there are issues in the related repos for Storefront child themes compatibility and is being tracked separately.

@nerrad nerrad closed this as completed Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

No branches or pull requests

2 participants