Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix IconButton deprecations for supporting WordPress 5.4+ #3511

Closed
nerrad opened this issue Dec 7, 2020 · 0 comments · Fixed by #3547
Closed

Fix IconButton deprecations for supporting WordPress 5.4+ #3511

nerrad opened this issue Dec 7, 2020 · 0 comments · Fixed by #3547
Assignees
@Aljullu
Labels
focus: components Work that introduces new or updates existing components. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: technical debt This issue/PR represents/solves the technical debt of the project.
Milestone
4.1.0

Comments

@nerrad
Copy link
Contributor

nerrad commented Dec 7, 2020

WordPress 5.4 included an update to the @wordpress/components package that deprecates the usage of the IconButton component. The recommended replacement is to use Button instead.

Since we can bump the minimum WordPress version support from WordPress 5.3 to 5.4 as a part of the WooCommerce Blocks 4.1.0 release (in line with our L2 support policy), we should take care of these deprecations.

This will also address in part the following issues that were created as a part of our WP 5.6 audit:
@nerrad nerrad added focus: components Work that introduces new or updates existing components. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: technical debt This issue/PR represents/solves the technical debt of the project. type: wp dependency labels Dec 7, 2020
@nerrad nerrad added this to the 4.1.0 milestone Dec 7, 2020
@Aljullu Aljullu self-assigned this Dec 14, 2020
@Aljullu Aljullu mentioned this issue Dec 14, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Aljullu Aljullu

Labels
focus: components Work that introduces new or updates existing components. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

Replace IconButton component with Button woocommerce/woocommerce-blocks
2 participants
@nerrad @Aljullu