Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Twenty Twenty One: selects are barely visible in dark mode #3518

Closed
Aljullu opened this issue Dec 7, 2020 · 0 comments · Fixed by #3554
Closed

Twenty Twenty One: selects are barely visible in dark mode #3518

Aljullu opened this issue Dec 7, 2020 · 0 comments · Fixed by #3554
Assignees
@opr
Labels
block: checkout Issues related to the checkout block. focus: components Work that introduces new or updates existing components. focus: global styles Issues that involve styles/css/layout structure. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Dec 7, 2020

To reproduce

  1. Install and activate Twenty Twenty One.
  2. Go to Customize > Colors & Dark mode and check the Dark mode support checkbox.
  3. In the frontend, make sure the dark mode is enabled and go to a page with the Checkout block.
  4. Open any select and notice the text is barely visible:

imatge

Expected behavior

There should be more contrast between the select background and content.
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. focus: components Work that introduces new or updates existing components. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. labels Dec 7, 2020
@nerrad nerrad added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Dec 10, 2020
@opr opr self-assigned this Dec 15, 2020
@opr opr mentioned this issue Dec 15, 2020
Merged
1 task
@opr opr closed this as completed in #3554 Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@opr opr

Labels
block: checkout Issues related to the checkout block. focus: components Work that introduces new or updates existing components. focus: global styles Issues that involve styles/css/layout structure. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix select inputs when dark mode is enabled in Twenty Twenty-One woocommerce/woocommerce-blocks
3 participants
@nerrad @Aljullu @opr