Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product title in Cart should inherit link styles #3628

Closed
senadir opened this issue Jan 4, 2021 · 3 comments
Closed

Product title in Cart should inherit link styles #3628

senadir opened this issue Jan 4, 2021 · 3 comments
Labels
focus: global styles Issues that involve styles/css/layout structure. type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@senadir
Copy link
Member

senadir commented Jan 4, 2021 •
edited

Based on the new design iteration for Cart, the product title is going to inherit link styles.

figma file: n90hX6hG3wwQbYwsYsrJnj-fi-5119%3A0

screenshot
image
image

The product title inherits the link color and styles from the theme. In the checkout meta, the product title isn’t linked. This is intentional to avoid directing the customer away from completing the checkout process.
@senadir senadir added the type: enhancement The issue is a request for an enhancement. label Jan 4, 2021
@senadir senadir changed the title Product title in Cart and Checkout should inherit link styles Product title in Cart should inherit link styles Jan 4, 2021
@nerrad
Copy link
Contributor

nerrad commented Feb 2, 2021

We're going to do a review of polish type issues at a later stage in the C&C blocks roadmap so I'm adding to the backlog for now.

@nerrad nerrad added focus: global styles Issues that involve styles/css/layout structure. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. labels Feb 2, 2021
@opr
Copy link
Contributor

opr commented Feb 2, 2021

@nerrad this was done in #3734 - I didn't notice this issue existed because I was just looking at ones with the subscription integration in the title.

@nerrad
Copy link
Contributor

nerrad commented Feb 2, 2021

Awesome! Nice I can close it then :)

@nerrad nerrad closed this as completed Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
focus: global styles Issues that involve styles/css/layout structure. type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nerrad @opr @senadir