Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Implement code needed for MailPoet integration #3661

Closed
nerrad opened this issue Jan 8, 2021 · 6 comments · Fixed by #4197
Closed

Implement code needed for MailPoet integration #3661

nerrad opened this issue Jan 8, 2021 · 6 comments · Fixed by #4197
Assignees
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. type: enhancement The issue is a request for an enhancement.

Comments

@nerrad
Copy link
Contributor

nerrad commented Jan 8, 2021

From some conversations with the team, they shared the things they need for integrating and it looks like this is all server side.

The following hooks:

woocommerce_add_to_cart
woocommerce_cart_item_removed
woocommerce_after_cart_item_quantity_update
woocommerce_before_cart_item_quantity_zero
woocommerce_cart_emptied
woocommerce_cart_item_restored

And then this was also mentioned:

I think all we really need is a hook, from which we can get an email entered in the checkout. If the above-mentioned hooks stay the same, we’ll use the new hook to update the email address to send abandoned cart to.

Once we work on this, we will need to clarify at what point they need the email, but I'm just documenting this for planning. I think most of the cart hooks should already be firing but we'll just need to confirm.

@nerrad nerrad added category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. type: enhancement The issue is a request for an enhancement. block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Jan 8, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 10, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 10, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label May 10, 2021
@mikejolley
Copy link
Member

@nerrad I think this issue is unnecessary. Store API goes through the main core Cart class, so those (where applicable) hooks are already fired. I have confirmed this.

Regarding the second point:

I think all we really need is a hook, from which we can get an email entered in the checkout. If the above-mentioned hooks stay the same, we’ll use the new hook to update the email address to send abandoned cart to.

Sad times if there is no opt-in? But billing email can be gathered from either the global customer object, or the draft order. These are updated "on the fly" as the user progresses through checkout. I don't know what point they'd want to collect this but I guess they could look at order status changes (draft for example) and capture data at that point, or using regular save_post hooks.

There is also the checkout event 'set-email-address' dispatched on the client side when this email is provided. Not sure if that is useful or not.

@github-actions github-actions bot removed the status: stale Stale issues and PRs have had no updates for 60 days. label May 11, 2021
@nerrad
Copy link
Contributor Author

nerrad commented May 11, 2021

Oh good, so based on that, there's no extra work needed for MailPoet to integrate with the new checkout flow, other than the ability to add a potential opt-in checkbox?

@senadir
Copy link
Member

senadir commented May 11, 2021

Email is not persisted if you don't enter your shipping address, so if they're looking for it on the server, it's not there. However, they can use set-email-address and dispatch the email to server, they can also wait for #3150 to do that for them.

@openmindculture
Copy link

Please reopen, there is still no MailPoet checkbox in the WooCommerce block checkout.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants