Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

"By proceeding with your purchase [...]" Not Translated on Checkout Block #5005

Closed
igotdes opened this issue Oct 27, 2021 · 4 comments · Fixed by #5112
Closed

"By proceeding with your purchase [...]" Not Translated on Checkout Block #5005

igotdes opened this issue Oct 27, 2021 · 4 comments · Fixed by #5112
Labels
block: checkout Issues related to the checkout block. focus: i18n The issue/PR is related to internationalization. type: bug The issue/PR concerns a confirmed bug.

Comments

@igotdes
Copy link

igotdes commented Oct 27, 2021

Describe the bug

When using the Checkout block, "By proceeding with your purchase you agree to our Terms and Conditions and Privacy Policy" is not being translated even if translations for it exist.

To reproduce

Steps to reproduce the behavior:

  1. On WP Admin > Settings, set the Site Language to a language other than English like Español or Norsk bokmål.
  2. Make sure to download any translation updates under My Home > Updates
  3. Create a page, add the Checkout block to it, and save it
  4. Add a product to cart and view the checkout page created previously

Expected behavior

"By proceeding with your purchase you agree to our Terms and Conditions and Privacy Policy" should be translated.

Screenshots

Español - translation here
Translation-Checkout-Block-ES

Norsk bokmål - translation here
Translation-Checkout-Block-NO

Environment

WordPress:

  • Core version: 5.8.1
  • Gutenberg version: 11.7.1
  • WooCommerce version: 5.8.0
  • WooCommerce Blocks version: 6.1.0

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Chrome Version 95.0.4638.54 (Official Build) (x86_64)

Additional context

Reported in #4406259-zen.

@nielslange
Copy link
Member

Hello @igotdes 👋

Thanks for reporting this problem. I looked up this case and found out that the string in question was using the textdomain woo-gutenberg-product-blocks instead of the textdomain woo-gutenberg-products-blocks (note the missing s for products). Therefore, the available translations couldn't be picked up.

I created a fix for this problem with #5020. This fix needs to be reviewed first, then approved, then merged and finally shipped. I cannot give you an estimate yet, on when the fix will be shipped. However, in case the client is looking for a quick solution, you could suggest changing the string directly within the checkout block, as the string is editable:

Screen Shot 2021-10-28 at 11 06 50

@nielslange
Copy link
Member

@igotdes The problem you reported had been resolved. Would you mind informing the client accordingly?

@igotdes
Copy link
Author

igotdes commented Nov 30, 2021

@igotdes The problem you reported had been resolved. Would you mind informing the client accordingly?

Done! I've informed the user.

Thanks for working on this and for keeping me updated too, @nielslange!

@nielslange
Copy link
Member

Thank you for reaching out to the user, @igotdes! 🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. focus: i18n The issue/PR is related to internationalization. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants