Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product Search (editor): the block's input can be edited #5078

Closed
ralucaStan opened this issue Nov 5, 2021 · 1 comment · Fixed by #5122
Closed

Product Search (editor): the block's input can be edited #5078

ralucaStan opened this issue Nov 5, 2021 · 1 comment · Fixed by #5122
Labels
block: product search Issues related to the Product Search block. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@ralucaStan
Copy link
Contributor

ralucaStan commented Nov 5, 2021 •
edited

Describe the bug

The input from the Product search block has a value(Search products...) instead of a placeholder in the editor. The user can edit this value.

To reproduce

  1. Go to a page and add the Product search block
  2. Click on the input and see that you can remove the Search products... text

Expected behavior

The user should not be able to edit the input, as we don't allow this in other blocks
The "Search products..." should be the input's placeholder instead of the input's value

Screenshots

Screenshot 2021-11-05 at 12 40 42
@ralucaStan ralucaStan added type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. block: product search Issues related to the Product Search block. labels Nov 5, 2021
@ralucaStan ralucaStan changed the title The Product search block's input can be edited in the editor Product Search(editor): the block's input can be edited Nov 5, 2021
@ralucaStan ralucaStan changed the title Product Search(editor): the block's input can be edited Product Search (editor): the block's input can be edited Nov 5, 2021
@alexflorisca
Copy link
Member

We've investigated this and found that the text is editable because it controls the value of the product search placeholder on the front end. If we stop the text from being editable, it prevents merchants from being able to customize the product search block

@alexflorisca alexflorisca mentioned this issue Nov 10, 2021
Merged
2 tasks
@alexflorisca alexflorisca linked a pull request Nov 10, 2021 that will close this issue
Add a placeholder to the product search block editor #5122
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
block: product search Issues related to the Product Search block. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a placeholder to the product search block editor woocommerce/woocommerce-blocks
2 participants
@ralucaStan @alexflorisca