Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractProductGrid huge performance issues #42583

Open
kastriotkastrati opened this issue Sep 14, 2022 · 0 comments
Open

AbstractProductGrid huge performance issues #42583

kastriotkastrati opened this issue Sep 14, 2022 · 0 comments
Labels
block-type: product-grid Issues related to/affecting all product-grid type blocks. focus: performance The issue/PR is related to performance. team: Kirigami & Origami WC Store Editing (FSE) type: bug The issue is a confirmed bug.

Comments

@kastriotkastrati
Copy link

Hello, I am seeing huge performance issues stemming from the AbstractProductGrid implementation.
In a page with 3 blocks of 3x7 grid of products we are seeing response times of 4 seconds and upwards.

If I comment this part of the code or cache it super aggressively, the response times immediately jump to sub 500ms,

My initial suspicions are that the products on line 79; in the AbstractProductGrid file are queried inefficiently.

I'm also wary of this part, which might be a source of performance issues.

This issue makes AbstractProductGrid unusable in anything that is more complex.
I think we should look to improve the performance here.

To reproduce

Steps to reproduce the behavior:
Use n x n product grids where n is >~ 4 in multiple places in one page.

Expected behavior

Response times that are not as slow as 4 seconds and upwards

@kastriotkastrati kastriotkastrati added the type: bug The issue is a confirmed bug. label Sep 14, 2022
@opr opr added the focus: performance The issue/PR is related to performance. label Sep 14, 2022
@Aljullu Aljullu added the block-type: product-grid Issues related to/affecting all product-grid type blocks. label Feb 22, 2023
@nerrad nerrad added the team: Kirigami & Origami WC Store Editing (FSE) label Dec 1, 2023
@ObliviousHarmony ObliviousHarmony transferred this issue from woocommerce/woocommerce-blocks Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-type: product-grid Issues related to/affecting all product-grid type blocks. focus: performance The issue/PR is related to performance. team: Kirigami & Origami WC Store Editing (FSE) type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

4 participants