Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling the buttons on the mini-cart independently from the cart #745

Open
jorgeatorres opened this issue May 26, 2020 · 0 comments · May be fixed by #775
Open

Allow disabling the buttons on the mini-cart independently from the cart #745

jorgeatorres opened this issue May 26, 2020 · 0 comments · May be fixed by #775
Labels
good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc.

Comments

@jorgeatorres
Copy link
Member

Describe the bug

We have a section with mini-cart specific settings, but whether the buttons are enabled or not on the mini-cart is controlled by the "Enable PayPal Checkout on the cart page" setting, which also controls the cart page.
We could look into adding a setting specifically for the mini-cart that is independent from the cart one.

Related to #744.
@mattallan mattallan added the priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. label May 27, 2020
@james-allan james-allan added the good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Jun 9, 2020
@achyuthajoy achyuthajoy self-assigned this Jun 17, 2020
@achyuthajoy achyuthajoy linked a pull request Jun 19, 2020 that will close this issue
Open
3 tasks
@achyuthajoy achyuthajoy removed their assignment Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc.
Projects
None yet
Milestone
No milestone
4 participants
@jorgeatorres @achyuthajoy @mattallan @james-allan