Incorrect payment method ID set on subscriptions if processing UPE redirect fails

[james-allan]

Describe the bug

If the UPE redirect fails to process the payment, subscriptions purchased in the order can have the incorrect renewal processing payment method IDs stored. eg iDEAL rather than SEPA.

To Reproduce

Note: I'm not sure how to reproduce this consistantly.

Steps to reproduce the behavior:

1. Disable Legacy UPE if you have it enabled.
2. Enable the iDEAL payment method. You'll need EUR as your store currency and an eligible Stripe Account.
3. Add a subscription product to your cart.
4. Select iDEAL on checkout.
5. When redirected to the bank site leave that tab open.
6. View the subscriptions in your Admin dashboard and you'll notice they are set to iDEAL

7. On Aashik's site (as mentioned here p1712809597613569/1711687628.010049-slack-C7U3Y3VMY) completing the payment at Stripe and being redirect back to the site is resulting in a nonce error. See below.

8. The failure to process the payment redirect leads to the subscription remaining set to iDEAL rather than SEPA.

I assume the webhook comes in to successfully process the payment but it too doesn't update the subscriptions payment method.

Leaving a subscription as iDEAL will fail renewals as iDEAL cannot be used to process recurring payments.

Expected behavior

The subscription should be originally set to SEPA rather than iDEAL or the webhook processing of the should update it too.

[AashikP]

Customer report: 7951635-zd-a8c

I can replicate this consistently on my test site, but not on a new JN site.

Error after Accepting payment, and redirecting to site:

Though we see the error, the order is correctly set to Processing, and Subscription is set to active

Subscription:

Order:

---

• There is no option to process renewal for the Subscription by the admin - since Payment method is iDEAL

• Customer can't change the payment method from My Subscriptions page

• If you try to process renewal by manually running the scheduled renewal action for the Subscription, you see the same error as you would see if this happened automatically when it is time for renewal:

  

[AashikP]

An update from 7951635-zen

It seems that it randomly picks one order and says it is via iDeal - where it will not renew any subscription if it says iDeal. Whenever it says SEPA the renewal works fine.

On their site, there's no the link has expired error as we can see on my test site.