Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Form autofill doesn't work when using 1Password #5428

Closed
nielslange opened this issue Dec 21, 2021 · 7 comments
Closed

Form autofill doesn't work when using 1Password #5428

nielslange opened this issue Dec 21, 2021 · 7 comments
Labels
block: checkout Issues related to the checkout block. type: bug The issue/PR concerns a confirmed bug.

Comments

@nielslange
Copy link
Member

Describe the bug

In #4561, we ensured that autofill within the checkout blocks works as expected. While testing the WooCommerce Blocks 6.6.0 release, I discovered that the autofill functionality is working when using the native autofill functionality of Chrome, but not when using 1Password.

To reproduce

  1. Create a test page with the checkout block.
  2. Go to the shop page and add a product to the cart.
  3. Go to the checkout page and autofill the address using 1Password.
  4. Remove one of the required fields, e.g. the city, and click on place Order.
  5. Add the missing field using autofill of 1Password and click Place Order again.
  6. See that the input field still shows an error despite being filled.

Expected behavior

When using autofill the form using 1Password I expect that no form errors are visible.

Screenshots

autofill

Additional context

This is an extension to #4561.

@nielslange nielslange added type: bug The issue/PR concerns a confirmed bug. block: checkout Issues related to the checkout block. labels Dec 21, 2021
@mikejolley
Copy link
Member

cc @senadir

@opr
Copy link
Contributor

opr commented Dec 21, 2021

This works ok on non-localhost sites - set up a JN site to test this and you'll see it's not reproducible there. The error that seems to be happening locally is

Failed to fillFrame: Frame is missing uuid.
(anonymous) @ injected.js:4
(anonymous) @ injected.js:4
(anonymous) @ injected.js:4
n @ injected.js:4

from the 1Password JS files.

I created a post on their forums to see if we can get more info about this.

@opr
Copy link
Contributor

opr commented Jan 17, 2022

Further discussion happening on the 1Password forums https://1password.community/discussion/comment/625916/#Comment_625916

@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 19, 2022
@nielslange nielslange removed the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 21, 2022
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label May 21, 2022
@nielslange nielslange removed the status: stale Stale issues and PRs have had no updates for 60 days. label May 23, 2022
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 22, 2022
@nielslange nielslange removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 22, 2022
@ralucaStan
Copy link
Contributor

Just tested and autofill works with 1password

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

No branches or pull requests

4 participants