This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add bundle size github workflow #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow implements a bundle-size monitoring utility for our repository to give better metrics on increases in bundle-sizes. I basically copied the configuration for the WordPress gutenberg project workflow and it utilizes the [`preactjs/compressed-size-action`](https://github.com/preactjs/compressed-size-action). If this works well, it will replace our existing bundlesize implementation.
nerrad
added
tools
|
Size Change: 0 B Total Size: 2 MB ℹ️ View Unchanged
|
- remove build:ci because it was only used for bundlesize check. No need to build files for linting checks. - add lint:ci npm script for doing build lint checks - update travis job config to use new script and update title
|
This is a build tool only, so I'm going to go ahead and merge this. |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow implements a bundle-size monitoring utility for our repository to give better metrics on increases in bundle-sizes. I basically copied the configuration for the WordPress gutenberg project workflow and it utilizes the
preactjs/compressed-size-action.This will replace our existing bundlewatch implementation.
Benefits of the switch:
The only real downside to this switch is that we don't block merging pull with this. So there's no enforced size budgets. I'm not sure that's much of a downside though because our current pattern has been mostly to use this for awareness and we've generally bumped bundets to merge pulls (while having an issue for following up on size reviews).
So the big benefit here is getting actionable feedback on significant change (or improvements!!) on bundle sizes in context of the pull making those changes.