Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Avoid some theme style properties leaking into the Cart and Checkout select controls #2647

Merged
merged 1 commit into from Jun 5, 2020

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Jun 5, 2020

Some themes are adding styles to hovered buttons that don't make sense in our Select component (ie: Hello theme sets the button text color to white when hovered, making the text invisible). This PR explicitly defines all select styles for the different states, making it harder for themes to break the select component.

It also forces the text to be left-aligned.

Screenshots

Screenshot of the issue:
Peek 2020-06-05 10-49

How to test the changes in this Pull Request:

  1. In Storefront (and, optionally, other themes), make sure there are no regressions with selects in Cart & Checkout address forms.
  2. Install the Hello theme from Elementor and make sure text in selects is visible when hovered and is left aligned.

Changelog

Avoid some theme style properties leaking into the Cart and Checkout select controls.

@Aljullu Aljullu added status: needs review type: bug The issue/PR concerns a confirmed bug. labels Jun 5, 2020
@Aljullu Aljullu added this to the 2.7.0 milestone Jun 5, 2020
@Aljullu Aljullu requested a review from a team as a code owner June 5, 2020 08:57
@Aljullu Aljullu self-assigned this Jun 5, 2020
@Aljullu Aljullu requested review from nerrad and removed request for a team June 5, 2020 08:57
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2020

Size Change: -8 B (0%)

Total Size: 1.78 MB

Filename Size Change
build/style-rtl.css 16.5 kB -4 B (0%)
build/style.css 16.5 kB -4 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 7.26 kB 0 B
build/active-filters.js 7.89 kB 0 B
build/all-products-frontend.js 71.9 kB 0 B
build/all-products.js 15.7 kB 0 B
build/all-reviews-legacy.js 9.19 kB 0 B
build/all-reviews.js 9.46 kB 0 B
build/attribute-filter-frontend.js 16.7 kB 0 B
build/attribute-filter.js 11.5 kB 0 B
build/block-error-boundary-legacy.js 774 B 0 B
build/block-error-boundary.js 775 B 0 B
build/blocks-legacy.js 2.92 kB 0 B
build/blocks.js 2.92 kB 0 B
build/cart-frontend.js 113 kB 0 B
build/cart.js 32.3 kB 0 B
build/checkout-frontend.js 129 kB 0 B
build/checkout.js 37.9 kB 0 B
build/custom-select-control-style-legacy.js 782 B 0 B
build/custom-select-control-style.js 782 B 0 B
build/editor-legacy-rtl.css 12.5 kB 0 B
build/editor-legacy.css 12.5 kB 0 B
build/editor-rtl.css 13.5 kB 0 B
build/editor.css 13.5 kB 0 B
build/featured-category-legacy.js 7.26 kB 0 B
build/featured-category.js 7.53 kB 0 B
build/featured-product-legacy.js 9.5 kB 0 B
build/featured-product.js 9.79 kB 0 B
build/handpicked-products-legacy.js 6.9 kB 0 B
build/handpicked-products.js 7.18 kB 0 B
build/panel-style-legacy.js 773 B 0 B
build/panel-style.js 773 B 0 B
build/price-filter-frontend.js 14.1 kB 0 B
build/price-filter.js 9.98 kB 0 B
build/product-best-sellers-legacy.js 6.98 kB 0 B
build/product-best-sellers.js 7.24 kB 0 B
build/product-categories-legacy.js 3.22 kB 0 B
build/product-categories.js 3.21 kB 0 B
build/product-category-legacy.js 7.89 kB 0 B
build/product-category.js 8.15 kB 0 B
build/product-list-style-legacy.js 775 B 0 B
build/product-new-legacy.js 7.13 kB 0 B
build/product-new.js 7.41 kB 0 B
build/product-on-sale-legacy.js 7.5 kB 0 B
build/product-on-sale.js 7.8 kB 0 B
build/product-search-legacy.js 3.12 kB 0 B
build/product-search.js 3.36 kB 0 B
build/product-tag-legacy.js 6.07 kB 0 B
build/product-tag.js 6.33 kB 0 B
build/product-top-rated-legacy.js 7.11 kB 0 B
build/product-top-rated.js 7.38 kB 0 B
build/products-by-attribute-legacy.js 7.87 kB 0 B
build/products-by-attribute.js 8.13 kB 0 B
build/reviews-by-category-legacy.js 11.2 kB 0 B
build/reviews-by-category.js 11.5 kB 0 B
build/reviews-by-product-legacy.js 12.7 kB 0 B
build/reviews-by-product.js 13 kB 0 B
build/reviews-frontend-legacy.js 8.03 kB 0 B
build/reviews-frontend.js 8.95 kB 0 B
build/single-product-frontend.js 58.9 kB 0 B
build/single-product.js 14.2 kB 0 B
build/snackbar-notice-style-legacy.js 778 B 0 B
build/snackbar-notice-style.js 778 B 0 B
build/spinner-style-legacy.js 775 B 0 B
build/spinner-style.js 772 B 0 B
build/style-legacy-rtl.css 5.6 kB 0 B
build/style-legacy.css 5.61 kB 0 B
build/vendors-legacy.js 376 kB 0 B
build/vendors-style-legacy-rtl.css 1.65 kB 0 B
build/vendors-style-legacy.css 1.65 kB 0 B
build/vendors-style-legacy.js 105 B 0 B
build/vendors-style-rtl.css 1.65 kB 0 B
build/vendors-style.css 1.65 kB 0 B
build/vendors-style.js 105 B 0 B
build/vendors.js 473 kB 0 B
build/wc-blocks-data.js 7.08 kB 0 B
build/wc-blocks-middleware.js 932 B 0 B
build/wc-blocks-registry.js 1.78 kB 0 B
build/wc-payment-method-cheque.js 794 B 0 B
build/wc-payment-method-paypal.js 830 B 0 B
build/wc-payment-method-stripe.js 11.9 kB 0 B
build/wc-settings.js 2.14 kB 0 B
build/wc-shared-context.js 1.17 kB 0 B

compressed-size-action

@Aljullu Aljullu merged commit 8d392b1 into master Jun 5, 2020
@Aljullu Aljullu deleted the fix/custom-select-color-on-hover branch June 5, 2020 09:12
@Aljullu Aljullu mentioned this pull request Jun 8, 2020
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants