This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix Cart and Checkout sidebar styling issues #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
commented
Jun 11, 2020
| .wc-block-shipping-rates-control { | ||
| .wc-block-shipping-rates-control__package.components-panel__body { |
There was a problem hiding this comment.
The class .components-panel__body was used by the Panel component from @wordpress/components. Since we migrated to our own Panel component which has different classes, all the code below was dead code and can be safely removed.
|
Size Change: +485 B (0%) Total Size: 1.57 MB
ℹ️ View Unchanged
|
senadir
approved these changes
Jun 12, 2020
There was a problem hiding this comment.
This fixes the issues mentioned but I'm not really sure about the step title height being reduced, the text feels squeezed now, especially in 2020, maybe we can solve this another way? It's not really a huge deal, also we could give step titles margin-bottom to even out the missing spacing while keeping the alignment.
|
Thanks for reviewing @senadir. Good point with the titles. I think we want to inherit the line-height from the theme, so I wouldn't undo that. But taking a look at the new designs, it looks like the margins should be a bit bigger now than they were before. I updated them in 17f629c and this is how it looks now:
|
|
yeah, that should fix it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2503.
Fixes #2658.
Fixes #2663.
Fixes #2692.
Fixes #2693.
How to test the changes in this Pull Request:
#2503
#2658
#2663
Fixing this, made the Checkout headers not to be aligned when there are no express payment methods. This has been fixed in 185610e, but would be worth testing it too.
#2692
#2693
Changelog