Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove dashicon classes #2848

Merged
merged 1 commit into from Jul 10, 2020
Merged

Remove dashicon classes #2848

merged 1 commit into from Jul 10, 2020

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Jul 10, 2020

Fixes #2846.

How to test the changes in this Pull Request:

Testing means ensuring there are no visual regressions in the modified blocks:

  1. Cart: verify coupon chip close icon looks as it did.
    imatge
  2. Attribute Filter: set Query Type: AND, Display Style: Dropdown. Then, select a value and check that the cross icon still shows up correct.
    imatge

@Aljullu Aljullu added status: needs review focus: components Work that introduces new or updates existing components. type: refactor The issue/PR is related to refactoring. block: cart Issues related to the cart block. block: product search Issues related to the Product Search block. block: filter by attribute Issues related to the Filter by Attribute block. block: product categories list Issues related to the Product Categories List block. labels Jul 10, 2020
@Aljullu Aljullu added this to the 2.10.0 milestone Jul 10, 2020
@Aljullu Aljullu requested a review from a team as a code owner July 10, 2020 09:43
@Aljullu Aljullu self-assigned this Jul 10, 2020
@Aljullu Aljullu requested review from haszari and removed request for a team July 10, 2020 09:43
@github-actions
Copy link
Contributor

Size Change: -285 B (0%)

Total Size: 1.59 MB

Filename Size Change
build/active-filters-frontend.js 8.43 kB -40 B (0%)
build/active-filters.js 8.72 kB -26 B (0%)
build/all-products-frontend.js 41.3 kB -28 B (0%)
build/all-products.js 24.9 kB -43 B (0%)
build/attribute-filter-frontend.js 17.7 kB -30 B (0%)
build/attribute-filter.js 12.3 kB -19 B (0%)
build/cart-frontend.js 64.1 kB -53 B (0%)
build/cart.js 33.4 kB -18 B (0%)
build/checkout-frontend.js 80.9 kB +70 B (0%)
build/checkout.js 38.9 kB -18 B (0%)
build/single-product-frontend.js 44.1 kB -28 B (0%)
build/single-product.js 18.3 kB -31 B (0%)
build/style-rtl.css 18.1 kB -11 B (0%)
build/style.css 18.1 kB -10 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/all-reviews-legacy.js 9.29 kB 0 B
build/all-reviews.js 9.6 kB 0 B
build/block-error-boundary-legacy.js 775 B 0 B
build/block-error-boundary.js 774 B 0 B
build/blocks-legacy.js 3.21 kB 0 B
build/blocks.js 3.22 kB 0 B
build/custom-select-control-style-legacy.js 782 B 0 B
build/custom-select-control-style.js 783 B 0 B
build/editor-legacy-rtl.css 12.5 kB 0 B
build/editor-legacy.css 12.5 kB 0 B
build/editor-rtl.css 13.5 kB 0 B
build/editor.css 13.5 kB 0 B
build/featured-category-legacy.js 7.25 kB 0 B
build/featured-category.js 7.59 kB 0 B
build/featured-product-legacy.js 9.51 kB 0 B
build/featured-product.js 9.85 kB 0 B
build/handpicked-products-legacy.js 6.91 kB 0 B
build/handpicked-products.js 7.24 kB 0 B
build/price-filter-frontend.js 14.1 kB 0 B
build/price-filter.js 10.1 kB 0 B
build/product-best-sellers-legacy.js 6.99 kB 0 B
build/product-best-sellers.js 7.3 kB 0 B
build/product-categories-legacy.js 3.22 kB 0 B
build/product-categories.js 3.22 kB 0 B
build/product-category-legacy.js 7.91 kB 0 B
build/product-category.js 8.25 kB 0 B
build/product-list-style-legacy.js 775 B 0 B
build/product-new-legacy.js 7.14 kB 0 B
build/product-new.js 7.47 kB 0 B
build/product-on-sale-legacy.js 7.52 kB 0 B
build/product-on-sale.js 7.87 kB 0 B
build/product-search-legacy.js 3.13 kB 0 B
build/product-search.js 3.43 kB 0 B
build/product-tag-legacy.js 6.08 kB 0 B
build/product-tag.js 6.39 kB 0 B
build/product-top-rated-legacy.js 7.11 kB 0 B
build/product-top-rated.js 7.44 kB 0 B
build/products-by-attribute-legacy.js 7.88 kB 0 B
build/products-by-attribute.js 8.2 kB 0 B
build/reviews-by-category-legacy.js 11.3 kB 0 B
build/reviews-by-category.js 11.6 kB 0 B
build/reviews-by-product-legacy.js 12.8 kB 0 B
build/reviews-by-product.js 13.1 kB 0 B
build/reviews-frontend-legacy.js 8.16 kB 0 B
build/reviews-frontend.js 9 kB 0 B
build/snackbar-notice-style-legacy.js 778 B 0 B
build/snackbar-notice-style.js 779 B 0 B
build/spinner-style-legacy.js 771 B 0 B
build/spinner-style.js 772 B 0 B
build/style-legacy-rtl.css 5.56 kB 0 B
build/style-legacy.css 5.57 kB 0 B
build/vendors-legacy.js 367 kB 0 B
build/vendors-style-legacy-rtl.css 1.03 kB 0 B
build/vendors-style-legacy.css 1.03 kB 0 B
build/vendors-style-legacy.js 102 B 0 B
build/vendors-style-rtl.css 1.03 kB 0 B
build/vendors-style.css 1.03 kB 0 B
build/vendors-style.js 102 B 0 B
build/vendors.js 415 kB 0 B
build/wc-blocks-data.js 7.09 kB 0 B
build/wc-blocks-middleware.js 932 B 0 B
build/wc-blocks-registry.js 2.19 kB 0 B
build/wc-payment-method-bacs.js 791 B 0 B
build/wc-payment-method-cheque.js 794 B 0 B
build/wc-payment-method-paypal.js 830 B 0 B
build/wc-payment-method-stripe.js 11.9 kB 0 B
build/wc-settings.js 2.14 kB 0 B
build/wc-shared-context.js 1.51 kB 0 B

compressed-size-action

Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 - thanks for taking care of this! :shipit:

@nerrad nerrad merged commit b8d8baa into main Jul 10, 2020
@nerrad nerrad deleted the fix/2846-remove-dashicon-classes branch July 10, 2020 18:20
@nerrad nerrad mentioned this pull request Jul 20, 2020
21 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block: filter by attribute Issues related to the Filter by Attribute block. block: product categories list Issues related to the Product Categories List block. block: product search Issues related to the Product Search block. focus: components Work that introduces new or updates existing components. type: refactor The issue/PR is related to refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect classname used for no-alt icon in the @woocommerce/icons library.
3 participants