Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Show Checkout block in editor also when guest checkout is not allowed #2958

Merged
merged 1 commit into from Aug 5, 2020

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Aug 4, 2020

Fixes #2943.

How to test the changes in this Pull Request:

  1. Go to WooCommerce > Settings > Accounts & Privacy and uncheck Allow customers to place orders without an account.
  2. Edit a page with the Checkout block.
  3. Verify the whole Checkout block is rendered in the editor, instead of only showing the You must be logged in to checkout. Click here to log in. message.

Changelog

Fixed an issue that was not rendering the Checkout block in editor when gues checkout was not allowed.

@Aljullu Aljullu added status: needs review type: bug The issue/PR concerns a confirmed bug. block: checkout Issues related to the checkout block. labels Aug 4, 2020
@Aljullu Aljullu added this to the 3.2.0 milestone Aug 4, 2020
@Aljullu Aljullu requested a review from a team as a code owner August 4, 2020 14:57
@Aljullu Aljullu self-assigned this Aug 4, 2020
@Aljullu Aljullu requested review from nerrad and removed request for a team August 4, 2020 14:57
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2020

Size Change: -3 B (0%)

Total Size: 1.65 MB

Filename Size Change
build/checkout-frontend.js 83 kB -2 B (0%)
build/checkout.js 39.9 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 8.49 kB 0 B
build/active-filters.js 8.77 kB 0 B
build/all-products-frontend.js 30.9 kB 0 B
build/all-products.js 35.3 kB 0 B
build/all-reviews-legacy.js 9.38 kB 0 B
build/all-reviews.js 9.7 kB 0 B
build/atomic-block-components/add-to-cart-frontend.js 8.73 kB 0 B
build/atomic-block-components/add-to-cart.js 7.32 kB 0 B
build/atomic-block-components/add-to-cart~atomic-block-components/button.js 3.12 kB 0 B
build/atomic-block-components/add-to-cart~atomic-block-components/image~atomic-block-components/title.js 334 B 0 B
build/atomic-block-components/button-frontend.js 1.99 kB 0 B
build/atomic-block-components/button.js 839 B 0 B
build/atomic-block-components/category-list-frontend.js 469 B 0 B
build/atomic-block-components/category-list.js 476 B 0 B
build/atomic-block-components/image-frontend.js 1.7 kB 0 B
build/atomic-block-components/image.js 1.15 kB 0 B
build/atomic-block-components/price-frontend.js 2.08 kB 0 B
build/atomic-block-components/price.js 2.11 kB 0 B
build/atomic-block-components/rating-frontend.js 524 B 0 B
build/atomic-block-components/rating.js 527 B 0 B
build/atomic-block-components/sale-badge-frontend.js 862 B 0 B
build/atomic-block-components/sale-badge.js 864 B 0 B
build/atomic-block-components/sku-frontend.js 388 B 0 B
build/atomic-block-components/sku.js 394 B 0 B
build/atomic-block-components/stock-indicator-frontend.js 568 B 0 B
build/atomic-block-components/stock-indicator.js 571 B 0 B
build/atomic-block-components/summary-frontend.js 919 B 0 B
build/atomic-block-components/summary.js 926 B 0 B
build/atomic-block-components/tag-list-frontend.js 464 B 0 B
build/atomic-block-components/tag-list.js 473 B 0 B
build/atomic-block-components/title-frontend.js 1.22 kB 0 B
build/atomic-block-components/title.js 1.05 kB 0 B
build/attribute-filter-frontend.js 17.8 kB 0 B
build/attribute-filter.js 12.3 kB 0 B
build/blocks-legacy.js 3.54 kB 0 B
build/blocks.js 3.54 kB 0 B
build/cart-frontend.js 66 kB 0 B
build/cart.js 34.5 kB 0 B
build/editor-legacy-rtl.css 13.8 kB 0 B
build/editor-legacy.css 13.8 kB 0 B
build/editor-rtl.css 14 kB 0 B
build/editor.css 14 kB 0 B
build/featured-category-legacy.js 7.28 kB 0 B
build/featured-category.js 7.65 kB 0 B
build/featured-product-legacy.js 9.53 kB 0 B
build/featured-product.js 9.89 kB 0 B
build/handpicked-products-legacy.js 6.93 kB 0 B
build/handpicked-products.js 7.29 kB 0 B
build/price-filter-frontend.js 14.2 kB 0 B
build/price-filter.js 10.2 kB 0 B
build/product-best-sellers-legacy.js 7.01 kB 0 B
build/product-best-sellers.js 7.36 kB 0 B
build/product-categories-legacy.js 3.23 kB 0 B
build/product-categories.js 3.23 kB 0 B
build/product-category-legacy.js 7.93 kB 0 B
build/product-category.js 8.31 kB 0 B
build/product-new-legacy.js 7.17 kB 0 B
build/product-new.js 7.53 kB 0 B
build/product-on-sale-legacy.js 7.55 kB 0 B
build/product-on-sale.js 7.92 kB 0 B
build/product-search-legacy.js 3.15 kB 0 B
build/product-search.js 3.48 kB 0 B
build/product-tag-legacy.js 6.1 kB 0 B
build/product-tag.js 6.44 kB 0 B
build/product-top-rated-legacy.js 7.14 kB 0 B
build/product-top-rated.js 7.5 kB 0 B
build/products-by-attribute-legacy.js 7.91 kB 0 B
build/products-by-attribute.js 8.24 kB 0 B
build/reviews-by-category-legacy.js 11.4 kB 0 B
build/reviews-by-category.js 11.7 kB 0 B
build/reviews-by-product-legacy.js 12.8 kB 0 B
build/reviews-by-product.js 13.3 kB 0 B
build/reviews-frontend-legacy.js 8.22 kB 0 B
build/reviews-frontend.js 9.08 kB 0 B
build/single-product-frontend.js 33.7 kB 0 B
build/single-product.js 10 kB 0 B
build/style-legacy-rtl.css 16.8 kB 0 B
build/style-legacy.css 16.8 kB 0 B
build/style-rtl.css 17.5 kB 0 B
build/style.css 17.5 kB 0 B
build/vendors-legacy.js 367 kB 0 B
build/vendors-style-legacy-rtl.css 1.03 kB 0 B
build/vendors-style-legacy.css 1.03 kB 0 B
build/vendors-style-rtl.css 1.03 kB 0 B
build/vendors-style.css 1.03 kB 0 B
build/vendors.js 416 kB 0 B
build/vendors~atomic-block-components/price-frontend.js 5.65 kB 0 B
build/wc-blocks-data.js 7.09 kB 0 B
build/wc-blocks-middleware.js 931 B 0 B
build/wc-blocks-registry.js 2.28 kB 0 B
build/wc-payment-method-bacs.js 790 B 0 B
build/wc-payment-method-cheque.js 796 B 0 B
build/wc-payment-method-cod.js 875 B 0 B
build/wc-payment-method-paypal.js 831 B 0 B
build/wc-payment-method-stripe.js 11.9 kB 0 B
build/wc-settings.js 2.14 kB 0 B
build/wc-shared-context.js 1.53 kB 0 B
build/wc-shared-hocs.js 1.66 kB 0 B

compressed-size-action

@Aljullu Aljullu merged commit 4c08ca0 into main Aug 5, 2020
@Aljullu Aljullu deleted the fix/2943-no-allows-guest-editor branch August 5, 2020 08:35
@senadir senadir mentioned this pull request Aug 19, 2020
20 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove coupling of checkout block rendering in editor to guest checkout setting.
3 participants