This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix All Products block 'No products' placeholder link #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
block: all products
Issues related to the all products block.
labels
Aug 4, 2020
Size Change: +4 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
senadir
approved these changes
Aug 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: all products
Issues related to the all products block.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2904 I noticed we were using the wrong variable name when importing the admin URL in the 'No products' placeholder of the All Products block.
How to test the changes in this Pull Request:
all-products/edit.js
as follows:Add new product
link and verify it works.Changelog